Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add generic NoExecute Toleration to NPD #45883

Merged
merged 1 commit into from
May 29, 2017
Merged

Add generic NoExecute Toleration to NPD #45883

merged 1 commit into from
May 29, 2017

Conversation

gmarek
Copy link
Contributor

@gmarek gmarek commented May 16, 2017

Ref. #44445

cc @davidopp

Add generic Toleration for NoExecute Taints to NodeProblemDetector

@gmarek gmarek added area/nodecontroller release-note Denotes a PR that will be considered when it comes time to generate release notes. labels May 16, 2017
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 16, 2017
@k8s-github-robot k8s-github-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 16, 2017
@gmarek gmarek added sig/node Categorizes an issue or PR as relevant to SIG Node. and removed area/nodecontroller labels May 16, 2017
@gmarek
Copy link
Contributor Author

gmarek commented May 25, 2017

Ping @dchen1107 @Random-Liu

@gmarek gmarek added this to the v1.7 milestone May 25, 2017
@gmarek
Copy link
Contributor Author

gmarek commented May 26, 2017

Ping @kubernetes/sig-node-pr-reviews

@dchen1107
Copy link
Member

/lgtm

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dchen1107, gmarek

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 26, 2017
@gmarek gmarek added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 29, 2017
@gmarek
Copy link
Contributor Author

gmarek commented May 29, 2017

@kubernetes/test-infra-maintainers - lgtm label was not automatically added.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 8c41dea into kubernetes:master May 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Random-Liu Random-Liu

@dchen1107 dchen1107

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.
5 participants
@gmarek @dchen1107 @k8s-github-robot @Random-Liu @k8s-ci-robot