Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lint failures on kubernetes-e2e charm #45832

Merged
merged 1 commit into from
May 16, 2017
Merged

Fix lint failures on kubernetes-e2e charm #45832

merged 1 commit into from
May 16, 2017

Conversation

Cynerva
Copy link
Contributor

@Cynerva Cynerva commented May 15, 2017

What this PR does / why we need it:

This fixes a test failure on the kubernetes-e2e charm relating to tox and flake8:

DEBUG:runner:/bin/sh: 1: flake8: not found

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

This is a follow-up to #45494 where the same thing was done for kubernetes-master.

Release note:

Fix lint failures on kubernetes-e2e charm

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 15, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @Cynerva. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 15, 2017
@k8s-github-robot k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels May 15, 2017
@lazypower
Copy link
Contributor

/assign @chuckbutler

@lazypower
Copy link
Contributor

+1 LGTM. Thanks for this cleanup for automated testing @Cynerva

I pulled this branch down and verified it works

/lgtm

  xenial  charles  ⋯  juju  layers  kubernetes-e2e  charm build -r --no-local-layers
build: Composing into /home/charles/work
build: Destination charm directory: /home/charles/work/builds/kubernetes-e2e
build: Processing layer: layer:basic
build: Processing layer: layer:tls-client
build: Processing layer: layer:snap
build: Processing layer: kubernetes-e2e (from .)
build: Processing interface: tls-certificates
build: Processing interface: http
build:
build: ---------------------------------------
build:               Build Report
build: ---------------------------------------
build: New build; all files were modified.
proof: I: all charms should provide at least one thing
  xenial  charles  ⋯  juju  layers  kubernetes-e2e  cd ~/work/builds/kubernetes-e2e/
  xenial  charles  ~  work  builds  kubernetes-e2e  make lint
py34 create: /media/psf/Home/work/builds/kubernetes-e2e/.tox/py34
ERROR: InterpreterNotFound: python3.4
py35 create: /media/psf/Home/work/builds/kubernetes-e2e/.tox/py35
py35 installdeps: -r/media/psf/Home/work/builds/kubernetes-e2e/requirements.txt
py35 installed: appdirs==1.4.3,flake8==3.3.0,mccabe==0.6.1,packaging==16.8,py==1.4.33,pycodestyle==2.3.1,pyflakes==1.5.0,pyparsing==2.2.0,pytest==3.0.7,six==1.10.0
______________________________________________________________________________________ summary ______________________________________________________________________________________
SKIPPED:  py34: InterpreterNotFound: python3.4
  py35: skipped tests
  congratulations :)
I: all charms should provide at least one thing
  xenial  charles  ~  work  builds  kubernetes-e2e  echo $?
0

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 15, 2017
@lazypower
Copy link
Contributor

@k8s-bot ok to test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 15, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cynerva, chuckbutler

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 15, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 44337, 45775, 45832, 45574, 45758)

@k8s-github-robot k8s-github-robot merged commit ba69aa9 into kubernetes:master May 16, 2017
@lazypower lazypower deleted the gkk/fix-e2e-lint branch May 16, 2017 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lazypower lazypower

@thockin thockin

@david-mcmahon david-mcmahon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Cynerva @k8s-ci-robot @lazypower @k8s-github-robot @thockin @david-mcmahon