Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't append :443 to registry domain in the kubernetes-worker layer registry action #45550

Merged
merged 1 commit into from
May 11, 2017
Merged

Don't append :443 to registry domain in the kubernetes-worker layer registry action #45550

merged 1 commit into from
May 11, 2017
+1 −1

Conversation

jacekn
Copy link

@jacekn jacekn commented May 9, 2017

What this PR does / why we need it: Fixes #45547

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #45547

Special notes for your reviewer:

Release note:

Fix #45547 - don't append :443 to juju created docker registry config

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 9, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @jacekn. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-reviewable
Copy link

This change is Reviewable

@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels May 9, 2017
@mikedanese mikedanese assigned mbruzek and unassigned mikedanese May 9, 2017
@lazypower
Copy link
Contributor

/assign @chuckbutler

@lazypower
Copy link
Contributor

@k8s-bot ok to test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 10, 2017
@lazypower
Copy link
Contributor

@k8s-bot kops aws e2e test this

@lazypower
Copy link
Contributor

/approve

@lazypower
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 10, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chuckbutler, jacekn

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 10, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 45569, 45602, 45604, 45478, 45550)

@k8s-github-robot k8s-github-robot merged commit 4b2ab4e into kubernetes:master May 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lazypower lazypower

@mbruzek mbruzek

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

kubernetes-master layer creates partially broken dockercfg
7 participants
@jacekn @k8s-ci-robot @k8s-reviewable @lazypower @k8s-github-robot @mikedanese @mbruzek