Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azure: load balancer: support UDP, fix multiple loadBalancerSourceRanges support, respect sessionAffinity #45523

Merged
merged 4 commits into from
May 10, 2017
Merged

azure: load balancer: support UDP, fix multiple loadBalancerSourceRanges support, respect sessionAffinity #45523

merged 4 commits into from
May 10, 2017

Conversation

colemickens
Copy link
Contributor

@colemickens colemickens commented May 9, 2017 •
edited by enisoc
Loading

What this PR does / why we need it:

  1. Adds support for UDP ports
  2. Fixes support for multiple loadBalancerSourceRanges
  3. Adds support the Service spec's sessionAffinity
  4. Removes dead code from the Instances file

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #43683

Special notes for your reviewer: n/a

Release note:

Azure: Fix support for multiple `loadBalancerSourceRanges`, and add support for UDP ports and the Service spec's `sessionAffinity`.

@colemickens
azure: loadbalancer: respect svc sessionaffinity
8b50b83 
If the Service spec sets sessionAffinity, reflects that in the
configuration specified for the Azure loadbalancer.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 9, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-github-robot k8s-github-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels May 9, 2017
@colemickens
Copy link
Contributor Author

/assign @brendandburns

@colemickens
azure: loadbalancer: support UDP svc ports+rules
355c2be
@colemickens
azure: loadbalancer: fix sourceAddrPrefix support
c349d36 
Fixes support for multiple instances of loadBalancerSourceRanges.
Previously, the names of the rules for each address range conflicted
causing only one to be applied. Now each gets a unique name.
@jpoon
Copy link

jpoon commented May 9, 2017

Thanks @colemickens. This PR fixes #43683

@karataliu karataliu mentioned this pull request May 10, 2017
Closed
@brendandburns
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 10, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, colemickens

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 3fbfafd into kubernetes:master May 10, 2017
@anhowe anhowe mentioned this pull request May 17, 2017
Closed
@jpoon jpoon mentioned this pull request May 20, 2017
Merged
k8s-github-robot pushed a commit that referenced this pull request Jun 7, 2017
Merge pull request #46174 from jpoon/automated-cherry-pick-of-#45523-…
62f1e62 
…upstream-release-1.6

Automatic merge from submit-queue

Automated cherry pick of #45523

Cherry pick of #45523 on release-1.6.

#45523: azure: loadbalancer: respect svc sessionaffinity
This was referenced Jun 7, 2017
Closed
Closed
@jpoon jpoon mentioned this pull request Jul 12, 2017
Closed
@karataliu karataliu mentioned this pull request Aug 3, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@thockin thockin

@brendandburns brendandburns

@derekwaynecarr derekwaynecarr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When using Azure provider, not able to expose a service using UDP protocol
8 participants
@colemickens @k8s-reviewable @jpoon @brendandburns @k8s-github-robot @thockin @derekwaynecarr @k8s-ci-robot