Fetch VM UUID from - /sys/class/dmi/id/product_serial #45311
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
This change is |
k8s-github-robot
added
size/M
k8s-ci-robot
added
the
needs-ok-to-test
|
Hi @divyenpatel. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
|
||
| // check the uuid starts with "VMware-" | ||
| if !strings.HasPrefix(uuidstr, UUIDPrefix) { | ||
| return "", fmt.Errorf("cannot find this VM's UUID") |
There was a problem hiding this comment.
How about recording the uuidstr in error info?
There was a problem hiding this comment.
added uuid in the error.
return "", fmt.Errorf("Failed to match Prefix, UUID read from the file is %v", uuidFromFile)
| uuidstr = strings.Replace(uuidstr[len(UUIDPrefix):(len(uuidstr)-1)], " ", "", -1) | ||
|
|
||
| // need to add dashes, e.g. "564d395e-d807-e18a-cb25-b79f65eb2b9f" | ||
| uuidstr = fmt.Sprintf("%s-%s-%s-%s", uuidstr[0:8], uuidstr[8:12], uuidstr[12:21], uuidstr[21:]) |
There was a problem hiding this comment.
Validate the length of uuidstr in case it's shorter than expected by accident.
There was a problem hiding this comment.
verified length
if len(uuid) != 32 {
return "", fmt.Errorf("Length check failed, UUID read from the file is %v", uuidFromFile)
}
|
@k8s-bot ok to test |
k8s-ci-robot
removed
the
needs-ok-to-test
divyenpatel
force-pushed
the
fix_fetch_VM_UUID
branch
2 times, most recently
from
ce2aa81
to
e086d0a
Compare
divyenpatel
force-pushed
the
fix_fetch_VM_UUID
branch
from
e086d0a
to
6886d69
Compare
|
@k8s-bot gce etcd3 e2e test this |
1 similar comment
|
@k8s-bot gce etcd3 e2e test this |
|
@dims all tests passed. Can you help merging this change to master? |
|
/assign @luomiao |
|
/approve |
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, divyenpatel, luomiao
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
k8s-github-robot
added
the
approved
|
Automatic merge from submit-queue (batch tested with PRs 41903, 45311, 45474, 45472, 45501) |
enisoc
added
the
release-note
enisoc
removed
the
release-note-none
…45311-kubernetes-release-1.6 Automatic merge from submit-queue Automated cherry pick of #45311 #43545 upstream release 1.6 Cherry pick of #45311 #43545 on release-1.6. #45311: Fetch VM UUID from - /sys/class/dmi/id/product_serial #43545: Remove credentials on worker nodes for vSphere cloud provider. @luomiao @BaluDontu @abrarshivani @tusharnt
What this PR does / why we need it:
Current code fetch VM uuid using uuid reported at
'/sys/devices/virtual/dmi/id/product_uuid'.This doesn't work with all the distros like Ubuntu 16.04 and Fedora.updating code to fetch VM uuid from
/sys/class/dmi/id/product_serialWhich issue this PR fixes
fixes #
Special notes for your reviewer:
Verified UUID is matching with VM UUID on ubuntu 16.04, Cent OS 7.3 , and Photon OS
@BaluDontu @tusharnt
Release note: