Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apimachinery: make explicit that meta.KindToResource is only a guess #45272

Merged
merged 2 commits into from
May 3, 2017
Merged

apimachinery: make explicit that meta.KindToResource is only a guess #45272

merged 2 commits into from
May 3, 2017
+14 −20

Conversation

sttts
Copy link
Contributor

@sttts sttts commented May 3, 2017 •
edited
Loading

All non-test code using KindToResource is suspicious and should be fixed with a real RESTMapper.

@k8s-reviewable
Copy link

This change is Reviewable

@k8s-github-robot k8s-github-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 3, 2017
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 3, 2017
@sttts sttts force-pushed the sttts-unsafe-guess-kindtoresource branch from 9812c27 to b0b7111 Compare May 3, 2017 07:49
@deads2k
Copy link
Contributor

deads2k commented May 3, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 3, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, sttts

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels May 3, 2017
@sttts sttts added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-label-needed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels May 3, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 45272, 45115)

@k8s-github-robot k8s-github-robot merged commit d21fa46 into kubernetes:master May 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@caesarxuchao caesarxuchao

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sttts @k8s-reviewable @deads2k @k8s-github-robot @caesarxuchao @k8s-ci-robot