Same internal and external ip for vSphere Cloud Provider #45201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
This change is |
k8s-github-robot
added
approved
|
/unassign @dims |
abrarshivani
changed the title
divyenpatel
reviewed
May 4, 2017
| Address: ip, | ||
| }, | ||
| ) | ||
| for _, ip := range v.IpAddress { |
There was a problem hiding this comment.
There is PR in review from @BaluDontu touching the same code - #45181
Can we merge both PRs to reduce cherry pick the resolve conflict effort?
|
We have e2e test which uses common func from https://github.com/kubernetes/kubernetes/blob/master/test/e2e/framework/util.go#L4506, this returns first address in the range Can we ssh into node using any returned IP address? |
|
@divyenpatel Yes, we can ssh into node using any returned IP address as long as you are running tests from the external network defined for the VMs. |
|
@bprashanth Can you please review this PR? |
|
lgtm |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
k8s-github-robot
added
do-not-merge
k8s-github-robot
removed
lgtm
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abrarshivani, luomiao
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
@bprashanth can you help removing "do-not-merge" label. |
|
/release-note |
k8s-ci-robot
added
release-note
saad-ali
removed
the
do-not-merge
|
Automatic merge from submit-queue |
k8s-github-robot
pushed a commit
that referenced
this pull request
May 23, 2017
…-upstream-release-1.6 Automatic merge from submit-queue Automated cherry pick of #45201 upstream release 1.6 Cherry pick of #45201 on release-1.6. #45201 : Same internal and external ip for vSphere Cloud Provider. @BaluDontu @tusharnt
cbonte
added a commit
to cbonte/kubernetes
that referenced
this pull request
Jul 19, 2017
When a node IP is set and a cloud provider returns the same address with several types, on the first address was accepted. With the changes made in PR kubernetes#45201, the vSphere cloud provider returned the ExternalIP first, which led to a node without any InternalIP. The behaviour is modified to return all the address types for the specified node IP. Issue kubernetes#48760
cbonte
added a commit
to cbonte/kubernetes
that referenced
this pull request
Aug 29, 2017
When a node IP is set and a cloud provider returns the same address with several types, on the first address was accepted. With the changes made in PR kubernetes#45201, the vSphere cloud provider returned the ExternalIP first, which led to a node without any InternalIP. The behaviour is modified to return all the address types for the specified node IP. Issue kubernetes#48760
vdemeester
pushed a commit
to vdemeester/kubernetes
that referenced
this pull request
Sep 7, 2017
Automatic merge from submit-queue (batch tested with PRs 51728, 49202) Fix setNodeAddress when a node IP and a cloud provider are set **What this PR does / why we need it**: When a node IP is set and a cloud provider returns the same address with several types, only the first address was accepted. With the changes made in PR kubernetes#45201, the vSphere cloud provider returned the ExternalIP first, which led to a node without any InternalIP. The behaviour is modified to return all the address types for the specified node IP. **Which issue this PR fixes**: fixes kubernetes#48760 **Special notes for your reviewer**: * I'm not a golang expert, is it possible to mock `kubelet.validateNodeIP()` to avoid the need of real host interface addresses in the test ? * It would be great to have it backported for a next 1.6.8 release. **Release note**: ```release-note NONE ```
cbonte
added a commit
to cbonte/kubernetes
that referenced
this pull request
Sep 8, 2017
When a node IP is set and a cloud provider returns the same address with several types, on the first address was accepted. With the changes made in PR kubernetes#45201, the vSphere cloud provider returned the ExternalIP first, which led to a node without any InternalIP. The behaviour is modified to return all the address types for the specified node IP. Issue kubernetes#48760
cbonte
added a commit
to cbonte/kubernetes
that referenced
this pull request
Sep 9, 2017
When a node IP is set and a cloud provider returns the same address with several types, on the first address was accepted. With the changes made in PR kubernetes#45201, the vSphere cloud provider returned the ExternalIP first, which led to a node without any InternalIP. The behaviour is modified to return all the address types for the specified node IP. Issue kubernetes#48760
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, vSphere Cloud Provider reports internal ip as container ip addresses. This PR modifies vSphere Cloud Provider to report same ip address as both internal and external that is provided by vmware infrastructure.
cc @pdhamdhere @tusharnt @BaluDontu @divyenpatel @luomiao