Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds the cifs-common package #45117

Merged
merged 1 commit into from
Apr 29, 2017
Merged

Adds the cifs-common package #45117

merged 1 commit into from
Apr 29, 2017

Conversation

lazypower
Copy link
Contributor

What this PR does / why we need it: Enables mounting of CIFS volumes. Required for Azure.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes https://github.com/juju-solutions/bundle-canonical-kubernetes/issues/227

Release note:

Added CIFS PV support for Juju Charms

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 28, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-github-robot k8s-github-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Apr 28, 2017
@lazypower
Copy link
Contributor Author

/assign @wwwtyro

@k8s-ci-robot
Copy link
Contributor

@chuckbutler: GitHub didn't allow me to assign the following users: wwwtyro.

Note that only kubernetes members can be assigned..

In response to this:

/assign @wwwtyro

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lazypower
Copy link
Contributor Author

/assign @marcoceppi

@marcoceppi
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 28, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chuckbutler, marcoceppi

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 41583, 45117, 45123)

@k8s-github-robot k8s-github-robot merged commit 02f9d60 into kubernetes:master Apr 29, 2017
@lazypower lazypower deleted the add-cifs branch May 1, 2017 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@marcoceppi marcoceppi

@j3ffml j3ffml

@david-mcmahon david-mcmahon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Include cifs-utils when on Azure
7 participants
@lazypower @k8s-reviewable @k8s-ci-robot @marcoceppi @k8s-github-robot @j3ffml @david-mcmahon