Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align Extender's validation with prioritizers. #45091

Merged
merged 1 commit into from
Apr 30, 2017
Merged

Align Extender's validation with prioritizers. #45091

merged 1 commit into from
Apr 30, 2017

Conversation

k82cn
Copy link
Member

@k82cn k82cn commented Apr 28, 2017

What this PR does / why we need it:
Align Extender's validation with prioritizers.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes # N/A

Release note:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 28, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: k82cn
We suggest the following additional approver: davidopp

Assign the PR to them by writing /assign @davidopp in a comment when ready.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Apr 28, 2017
@k82cn
Copy link
Member Author

k82cn commented Apr 28, 2017

/cc @ravigadde

@k8s-ci-robot
Copy link
Contributor

@k82cn: GitHub didn't allow me to request PR reviews from the following users: ravigadde.

Note that only people with write access to kubernetes/kubernetes can review this PR.
.

In response to this:

/cc @ravigadde

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k82cn
Copy link
Member Author

k82cn commented Apr 28, 2017

@k8s-bot unit test this

ravigadde
ravigadde approved these changes Apr 28, 2017
View reviewed changes
Copy link
Contributor

@ravigadde ravigadde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@timothysc timothysc added the sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. label Apr 28, 2017
@timothysc timothysc added this to the v1.7 milestone Apr 28, 2017
@timothysc timothysc added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 28, 2017
@k82cn
Copy link
Member Author

k82cn commented Apr 30, 2017

@k8s-bot unit test this

@timothysc timothysc added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 30, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 05fafe1 into kubernetes:master Apr 30, 2017
@k82cn k82cn deleted the update_weight_check branch May 8, 2017 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ravigadde ravigadde ravigadde approved these changes

Assignees

@timothysc timothysc

@davidopp davidopp

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.
7 participants
@k82cn @k8s-reviewable @k8s-github-robot @k8s-ci-robot @ravigadde @timothysc @davidopp