Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cluster-autoscaler logging config #45017

Merged
merged 1 commit into from
Apr 27, 2017
Merged

Update cluster-autoscaler logging config #45017

merged 1 commit into from
Apr 27, 2017

Conversation

MaciekPytel
Copy link
Contributor

@MaciekPytel MaciekPytel commented Apr 27, 2017 •
edited by enisoc
Loading

Previously cluster-autoscaler would duplicate all logs,
writing to master /var/log and /tmp inside pod.

cluster-autoscaler: Fix duplicate writing of logs.

@MaciekPytel
Update cluster-autoscaler logging config
b6574bd 
Previously it would duplicate all logs,
writing to master /var/log and /tmp inside pod.
@MaciekPytel MaciekPytel added release-note-none Denotes a PR that doesn't merit a release note. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. labels Apr 27, 2017
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 27, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-github-robot k8s-github-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 27, 2017
@MaciekPytel MaciekPytel assigned wojtek-t and mwielgus and unassigned jbeda and mikedanese Apr 27, 2017
@crassirostris
Copy link

Thanks!

@mwielgus
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 27, 2017
@mwielgus mwielgus added this to the v1.6 milestone Apr 27, 2017
@wojtek-t
Copy link
Member

/approve

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MaciekPytel, mwielgus, wojtek-t

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 27, 2017
@MaciekPytel
Copy link
Contributor Author

@k8s-bot bazel test this

@MaciekPytel
Copy link
Contributor Author

@k8s-bot bazel test this
@k8s-bot gce etcd3 e2e test this

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 493e448 into kubernetes:master Apr 27, 2017
@MaciekPytel MaciekPytel mentioned this pull request Apr 27, 2017
Merged
@enisoc enisoc added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Apr 27, 2017
k8s-github-robot pushed a commit that referenced this pull request Apr 27, 2017
Merge pull request #45035 from MaciekPytel/automated-cherry-pick-of-#…
e62f7f1 
…45017-upstream-release-1.6

Automatic merge from submit-queue

Automated cherry pick of #45017

Cherry pick of #45017 on release-1.6.

#45017: Update cluster-autoscaler logging config
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.6" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwielgus mwielgus Awaiting requested review from mwielgus

Assignees

@wojtek-t wojtek-t

@mwielgus mwielgus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.6
Development

Successfully merging this pull request may close these issues.