Use munged semantic version for side-loaded docker tag #44981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
This change is |
k8s-github-robot
added
size/S
ixdy
force-pushed
the
version-docker-tag
branch
3 times, most recently
from
df74c10 to
52b9e4f
Compare
ixdy
added
release-note
ixdy
force-pushed
the
version-docker-tag
branch
from
52b9e4f to
f73e3cb
Compare
|
@k8s-bot verify test this |
|
I very much approve of this. I don't think there's any reason for the tags being this way other than that's how it was done 2 years ago. lgtm |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ixdy, lavalamp, mikedanese
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
k8s-github-robot
added
the
approved
|
Automatic merge from submit-queue |
k8s-github-robot
pushed a commit
that referenced
this pull request
May 5, 2017
Automatic merge from submit-queue Only tag release containers if the name is different. Fixes docker build issue found recently when trying to build v1.7.0-alpha.3. ref #44981
This was referenced Jun 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: rather than using the md5sum of the dockerized binary for each side-loaded docker image, use the semantic version (with
+s replaced with_s) for the side-loaded docker images.The use of the md5sum for the docker tag dates to #6326 2 years ago. I'm not sure why that was chosen, short of it being fairly unique.
My main motivation for changing this is that it makes building the docker images using Bazel's docker rules easier, since the semantic version doesn't depend on the build output.
An added benefit is that the list of images on a running kubernetes cluster is also more straightfoward; rather than a list of opaque, meaningless hexadecimal strings, you get something that indicates the provenance of the image. It'd also be clearer that all of the images came from the same build.
I was able to start a cluster with this change on GCE using both
make quick-releaseandmake bazel-release.Note that this change has no effect on the tag that's pushed to gcr.io during releases; that's still controlled via
KUBE_IMAGE_DOCKER_TAG, though we may want to merge this functionality at some point.@kubernetes/sig-node-pr-reviews is there any reason to stick with using the md5sum strategy? @dchen1107 do you remember why we went with md5sums originally?
cc @spxtr @mikedanese
Release note: