Allow pods to opt out of PodPreset mutation via an annotation on the pod #44965

jpeeler · 2017-04-26T18:46:37Z

An annotation in the pod spec of the form:
podpreset.admission.kubernetes.io/PodPresetOptOut: "true"
Will cause the admission controller to skip manipulating the pod spec,
no matter the labelling.

This is an alternative implementation to pull #44163.

Allow pods to opt out of PodPreset mutation via an annotation on the pod.

k8s-reviewable · 2017-04-26T18:46:43Z

This change is

k8s-ci-robot · 2017-04-26T18:46:44Z

Hi @jpeeler. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

spiffxp · 2017-05-08T16:26:23Z

@k8s-bot ok to test

pmorie · 2017-05-27T18:49:36Z

Added to the 1.7 milestones since this is critical to prevent abuse scenarios when coupled with service catalog.

pmorie · 2017-05-27T18:50:29Z

@jpeeler the description and title of this PR is identical to your other PR; will you please disambiguate them by changing the title and description?

smarterclayton · 2017-05-31T15:02:38Z

plugin/pkg/admission/podpreset/admission.go

@@ -38,6 +38,7 @@ import (

 const (
 	annotationPrefix = "podpreset.admission.kubernetes.io"
+	exclusionSuffix  = "PodPresetOptOut"


This isn't consistent with our other naming schemes for annotations - should be lower case with dashes between significant words.

should it also be moved to annotation_key_constants? maybe something like:

// PodPresetOptOutAnnotationKey represents the annotation key for a pod to exempt itself from pod preset manipulation PodPresetOptOutAnnotationKey string = "podpreset.admission.kubernetes.io/opt-out"

I definitely prefer we avoid repetition (podpreset...../PodPreset)

that annotation prefix is used on a pod to say what pod preset mutated its spec.

i think your key would mean that the "opt-out" pod preset had actually mutated it. we should have a different prefix.

typically, a pod will have an annotation that says:

"podpreset.admission.kubernetes.io/{pod-preset-name}" = {pod-preset-resource-version}" that mutated pod spec.

ideally, we would have made that annotation two keys rather than encoding it all in one.

i would be in favor of doing just that actually.

"podpreset.alpha.admission.kubernetes.io/name" - name of pod preset that mutated pod spec.
"podpreset.alpha.admission.kubernetes.io/resource-version" - resource version of pod preset that mutated pod spec.
"podpreset.alpha.admission.kubernetes.io/opt-out" - if true, opt-out of applying pod preset.

@pmorie - thoughts? i don't see why we cannot change how the annotation is applied here today given alpha nature of API.

https://github.com/kubernetes/kubernetes/blob/master/plugin/pkg/admission/podpreset/admission.go#L185

I like what you've suggested @derekwaynecarr

@derekwaynecarr we can definitely change it - but I believe that the reason we chose the current format is so we can record that multiple pod presets acted on a pod. What you have suggested doesn't seem to work for multiple pod presets.

@pmorie - ok.

then lets do the following:

podpreset.alpha.admission.kubernetes.io/podpreset-{name} = resource version
podpreset.alpha.admission.kubernetes.io/opt-out = true

that works for me

@derekwaynecarr where is the alpha text coming from? https://github.com/kubernetes/kubernetes/blob/master/plugin/pkg/admission/podpreset/admission.go#L40
Should the new annotation have alpha or not?

derekwaynecarr · 2017-05-31T15:07:56Z

agree with @smarterclayton on his syntax comment.

spoke with @pmorie @liggitt and got agreement that PodPreset is is a delegation mechanism versus an enforcement mechansim. as a result, having a means for a pod to opt-out is ok.

derekwaynecarr · 2017-05-31T15:35:27Z

i would prefer we merge this approach for 1.7 and hold on the alternative approach presented in #44163 pending more experience.

pmorie · 2017-05-31T17:27:27Z

See my comment here: #44965 (comment)

We need a way to unambiguously represent:

That a pod requests opt-out of mutation via PodPreset
That a pod was mutated by n PodPresets

jpeeler · 2017-05-31T20:44:55Z

This seems to be failing due to flake #46713

jpeeler · 2017-05-31T21:00:20Z

@k8s-bot gce etcd3 e2e test this

derekwaynecarr · 2017-05-31T21:25:38Z

pkg/api/annotation_key_constants.go

@@ -19,6 +19,9 @@ limitations under the License.
 package api

 const (
+	// PodPresetOptOutAnnotationKey represents the annotation key for a pod to exempt itself from pod preset manipulation
+	PodPresetOptOutAnnotationKey string = "podpreset.admission.kubernetes.io/podpreset-opt-out"


this doesnt match the v1 string.

remove the podpreset prefix in the suffix.

derekwaynecarr · 2017-05-31T21:27:17Z

staging/src/k8s.io/client-go/pkg/api/annotation_key_constants.go

@@ -19,6 +19,9 @@ limitations under the License.
 package api

 const (
+	// PodPresetOptOutAnnotationKey represents the annotation key for a pod to exempt itself from pod preset manipulation
+	PodPresetOptOutAnnotationKey string = "podpreset.admission.kubernetes.io/podpreset-opt-out"


same thing here.

derekwaynecarr · 2017-05-31T21:35:26Z

/approve
/lgtm

derekwaynecarr · 2017-06-05T16:51:36Z

/lgtm

k8s-github-robot · 2017-06-05T16:51:39Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekwaynecarr, jpeeler, smarterclayton

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

~~pkg/api/OWNERS~~ [smarterclayton]
~~plugin/pkg/admission/OWNERS~~ [derekwaynecarr,smarterclayton]
~~staging/src/k8s.io/client-go/pkg/api/OWNERS~~ [smarterclayton]
~~test/OWNERS~~ [smarterclayton]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

k8s-ci-robot · 2017-06-05T16:55:42Z

@jpeeler: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
Jenkins GCE etcd3 e2e	`eb256fb`	link	`@k8s-bot gce etcd3 e2e test this`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

derekwaynecarr · 2017-06-09T04:18:27Z

/retest

k8s-github-robot · 2017-06-09T05:57:34Z

Automatic merge from submit-queue

derekwaynecarr · 2017-06-09T19:38:49Z

@php-coder - agree. @jpeeler -- can you send those follow-ons?

The new format simply adds a prefix of "podpreset-" to the current annotation that records what presets have acted on a pod. The new naming makes it such that there is no chance of collision with the newly introduced opt-out annotation (or future ones yet to be added). Opt-out annotation PR: kubernetes/kubernetes#44965

This adds the annotation for having the podpreset admission controller to skip (opt-out) manipulating the pod spec. Also, the annotation format for what presets have acted on a pod has been modified to add a prefix of "podpreset-". The new naming makes it such that there is no chance of collision with the newly introduced opt-out annotation (or future ones yet to be added). Opt-out annotation PR: kubernetes/kubernetes#44965

@nikhiljindal

* Minor fixes in the Deployment doc Signed-off-by: Michail Kargakis <[email protected]> * add NodeRestriction to admission-controllers (#3842) * Admins Can Configure Zones in Storage Class The PR #38505 (kubernetes/kubernetes#38505) added zones optional parameter to Storage Class for AWS and GCE provisioners. That's why documentation needs to be updated accordingly. * document custom resource definitions * add host paths to psp (#3971) * add host paths to psp * add italics * Update ConfigMap doc to explain TTL-based cache updates (#3989) * Update ConfigMap doc to explain TTL-based cache updates * swap word order Change "When a ConfigMap being already consumed..." to "When a ConfigMap already being consumed..." * Update NetworkPolicy docs for v1 * StorageOS Volume plugin * Update GPU docs * docs: HPA autoscaling/v2alpha1 status conditions This commit documents the new status conditions feature for HPA autoscaling/v2alpha1. It demonstrates how to get the status conditions using `kubectl describe`, and how to interpret them. * Update description about NodeRestriction kubelet node can alse create mirror pods for their own static pods. * adding storage as a supported resource to node allocatable Signed-off-by: Vishnu kannan <[email protected]> * Add documentation for podpreset opt-out annotation This adds the annotation for having the podpreset admission controller to skip (opt-out) manipulating the pod spec. Also, the annotation format for what presets have acted on a pod has been modified to add a prefix of "podpreset-". The new naming makes it such that there is no chance of collision with the newly introduced opt-out annotation (or future ones yet to be added). Opt-out annotation PR: kubernetes/kubernetes#44965 * Update PDB documentation to explain new field (#3885) * update-docs-pdb * Addressed erictune@'s comments * Fix title and add a TOC to the logging concept page * Patch #4118 for typos * Describe setting coredns server in nameserver resolv chain * Address comments in PR #3997. Comment is in https://github.com/kubernetes/kubernetes.github.io/pull/3997/files/f6eb59c67e28efc298c87b1ef49a96bc6adacd1e#diff-7a14981f3dd8eb203f897ce6c11d9828 * Update task for DaemonSet history and rollback (#4098) * Update task for DaemonSet history and rollback Also remove mentions of templateGeneration field because it's deprecated * Address comments * removed lt and gt as operators (#4152) * removed lt and gt as operators * replace lt and gt for node-affinfity * updated based on bsalamat review * Initial draft of upgrade guide for kubeadm clusters. In-place upgrades are supported between 1.6 and 1.7 releases. Rollback instructions to come in a separate commit. Fixes kubernetes/kubeadm#278 * Add local volume documentation (#4050) * Add local volume documentation * Add PV local volume example * Patch PR #3999 * Add documentation for Stackdriver event exporter * Add documentation about controller metrics * Federation: Add task for setting up placement policies (#4075) * Add task for setting up placement policies * Update version of management sidecar in policy engine deployment * Address @nikhiljindal's comments - Lower case filenames - Comments in policy - Typo fixes - Removed type LoadBalancer from OPA Service * Add example that sets cluster selector Per-@nikhiljindal's suggestion * Fix wording and templating per @chenopis * PodDisruptionBudget documentation Improvements (#4140) * Changes from #3885 Title: Update PDB documentation to explain new field Author: foxish * Added Placeholder Disruptions Concept Guide New file: docs/concepts/workloads/pods/disruptions.md Intented contents: concept for Pod Disruption Budget, cross reference to Eviction and Preemption docs. Linked from: concepts > workloads > pods * Added placeholder Configuring PDB Task New file: docs/tasks/run-application/configure-pdb.md Intented contents: task for writing a Pod Disruption Budget. Linked from: tasks > configuring-applications > configure pdb. * Add refs to the "drain a node" task. * Refactor PDB docs. Move the "Requesting an eviction" section from: docs/tasks/administer-cluster/configure-pod-disruption-budget.md -- which is going away -- to: docs/tasks/administer-cluster/safely-drain-node.md The move is verbatim, except for an introductory sentence. Also added assignees. * Refactor of PDB docs Moved the section: Specifying a PodDisruptionBudget from: docs/tasks/administer-cluster/configure-pod-disruption-budget.md to: docs/tasks/run-application/configure-pdb.md because that former file is going away. Move is verbatim. * Explain how Eviction tools should handle failures * Refactor PDB docs Move text from: docs/tasks/administer-cluster/configure-pod-disruption-budget.md to: docs/concepts/workloads/pods/disruptions.md Delete the now empty: docs/tasks/administer-cluster/configure-pod-disruption-budget.md Added a redirects_from section to the new doc, containing the path of the now-deleted doc, plus all the redirects from the deleted doc. * Expand PDB Concept guide Building on a little content from the old task, greatly expanded the Disruptions concept guide, including an abstract example. * Update creating a pdb Task. * Address review comments. * Fixed for all cody-clark's review comments * Address review comments from mml * Address review comments from maisem * Fix missing backtick * Api and Kubectl reference docs updates for 1.7 (#4193) * Fix includes groups * Generated kubectl docs for 1.7 * Generated references docs for 1.7 api * Document node authorization mode * API Aggregator (#4173) * API Aggregator * Additional bullet points * incorporated feedback for apiserver-aggregation.md * split setup-api-aggregator.md into two docs and address feedback * fix link * addressed docs feedback * incorporate feedback * integrate feedback * Add documentation for DNS stub domains (#4063) * Add documentation for DNS stub domains * add additional prereq * fix image path * review feedback * minor grammar and style nits * documentation for using hostAliases to manage hosts file (#4080) * documentation for using hostAliases to manage hosts file * add to table of contents * review comments * update the right command to see hosts file * reformat doc based on suggestion and change some wording * Fix typo for #4080 * Patch PR #4063 * Fix wording in placement policy task introduction * Add update to statefulset concepts and basic tutorial (#4174) * Add update to statefulset concpets and basic tutorial * Address tech comments. * Update ESIPP docs for new added API fields * Custom resource docs * update audit document with advanced audit features added in 1.7 * kubeadm v1.7 documentation updates (#4018) * v1.7 updates for kubeadm * Address review comments * Address Luke's comments * Encrypting secrets at rest and cluster security guide * Edits for Custom DNS Documentation (#4207) * reorganize custom dns doc * format fixes * Update version numbers to 1.7 * Patch PR #4140 (#4215) * Patch PR #4140 * fix link and typos * Update PR template * Update TLS bootstrapping with 1.7 features This includes documenting the new CSR approver built into the controller manager and the kubelet alpha features for certificate rotation. Since the CSR approver changed over the 1.7 release cycle we need to call out the migration steps for those using the alpha feature. This document as a whole could probably use some updates, but the main focus of this PR is just to get these features minimally documented before the release. * Federated ClusterSelector formatting updates from review * complete PR #4181 (#4223) * complete PR #4181 * fix security link * Extensible admission controller (#4092) * extensible-admission-controllers * Update extensible-admission-controllers.md * more on initializers * fixes * Expand external admission webhooks documentation * wrap at 80 chars * more * add reference * Use correct apigroup for network policy * Docs changes to PR #4092 (#4224) * Docs changes to PR #4092 * address feedback * add doc for --as-group in cli Add doc for this pr: kubernetes/kubernetes#43696

This adds the annotation for having the podpreset admission controller to skip (opt-out) manipulating the pod spec. Also, the annotation format for what presets have acted on a pod has been modified to add a prefix of "podpreset-". The new naming makes it such that there is no chance of collision with the newly introduced opt-out annotation (or future ones yet to be added). Opt-out annotation PR: kubernetes/kubernetes#44965

@nikhiljindal

* Minor fixes in the Deployment doc Signed-off-by: Michail Kargakis <[email protected]> * add NodeRestriction to admission-controllers (#3842) * Admins Can Configure Zones in Storage Class The PR #38505 (kubernetes/kubernetes#38505) added zones optional parameter to Storage Class for AWS and GCE provisioners. That's why documentation needs to be updated accordingly. * document custom resource definitions * add host paths to psp (#3971) * add host paths to psp * add italics * Update ConfigMap doc to explain TTL-based cache updates (#3989) * Update ConfigMap doc to explain TTL-based cache updates * swap word order Change "When a ConfigMap being already consumed..." to "When a ConfigMap already being consumed..." * Update NetworkPolicy docs for v1 * StorageOS Volume plugin * Update GPU docs * docs: HPA autoscaling/v2alpha1 status conditions This commit documents the new status conditions feature for HPA autoscaling/v2alpha1. It demonstrates how to get the status conditions using `kubectl describe`, and how to interpret them. * Update description about NodeRestriction kubelet node can alse create mirror pods for their own static pods. * adding storage as a supported resource to node allocatable Signed-off-by: Vishnu kannan <[email protected]> * Add documentation for podpreset opt-out annotation This adds the annotation for having the podpreset admission controller to skip (opt-out) manipulating the pod spec. Also, the annotation format for what presets have acted on a pod has been modified to add a prefix of "podpreset-". The new naming makes it such that there is no chance of collision with the newly introduced opt-out annotation (or future ones yet to be added). Opt-out annotation PR: kubernetes/kubernetes#44965 * Update PDB documentation to explain new field (#3885) * update-docs-pdb * Addressed erictune@'s comments * Fix title and add a TOC to the logging concept page * Patch #4118 for typos * Describe setting coredns server in nameserver resolv chain * Address comments in PR #3997. Comment is in https://github.com/kubernetes/kubernetes.github.io/pull/3997/files/f6eb59c67e28efc298c87b1ef49a96bc6adacd1e#diff-7a14981f3dd8eb203f897ce6c11d9828 * Update task for DaemonSet history and rollback (#4098) * Update task for DaemonSet history and rollback Also remove mentions of templateGeneration field because it's deprecated * Address comments * removed lt and gt as operators (#4152) * removed lt and gt as operators * replace lt and gt for node-affinfity * updated based on bsalamat review * Initial draft of upgrade guide for kubeadm clusters. In-place upgrades are supported between 1.6 and 1.7 releases. Rollback instructions to come in a separate commit. Fixes kubernetes/kubeadm#278 * Add local volume documentation (#4050) * Add local volume documentation * Add PV local volume example * Patch PR #3999 * Add documentation for Stackdriver event exporter * Add documentation about controller metrics * Federation: Add task for setting up placement policies (#4075) * Add task for setting up placement policies * Update version of management sidecar in policy engine deployment * Address @nikhiljindal's comments - Lower case filenames - Comments in policy - Typo fixes - Removed type LoadBalancer from OPA Service * Add example that sets cluster selector Per-@nikhiljindal's suggestion * Fix wording and templating per @chenopis * PodDisruptionBudget documentation Improvements (#4140) * Changes from #3885 Title: Update PDB documentation to explain new field Author: foxish * Added Placeholder Disruptions Concept Guide New file: docs/concepts/workloads/pods/disruptions.md Intented contents: concept for Pod Disruption Budget, cross reference to Eviction and Preemption docs. Linked from: concepts > workloads > pods * Added placeholder Configuring PDB Task New file: docs/tasks/run-application/configure-pdb.md Intented contents: task for writing a Pod Disruption Budget. Linked from: tasks > configuring-applications > configure pdb. * Add refs to the "drain a node" task. * Refactor PDB docs. Move the "Requesting an eviction" section from: docs/tasks/administer-cluster/configure-pod-disruption-budget.md -- which is going away -- to: docs/tasks/administer-cluster/safely-drain-node.md The move is verbatim, except for an introductory sentence. Also added assignees. * Refactor of PDB docs Moved the section: Specifying a PodDisruptionBudget from: docs/tasks/administer-cluster/configure-pod-disruption-budget.md to: docs/tasks/run-application/configure-pdb.md because that former file is going away. Move is verbatim. * Explain how Eviction tools should handle failures * Refactor PDB docs Move text from: docs/tasks/administer-cluster/configure-pod-disruption-budget.md to: docs/concepts/workloads/pods/disruptions.md Delete the now empty: docs/tasks/administer-cluster/configure-pod-disruption-budget.md Added a redirects_from section to the new doc, containing the path of the now-deleted doc, plus all the redirects from the deleted doc. * Expand PDB Concept guide Building on a little content from the old task, greatly expanded the Disruptions concept guide, including an abstract example. * Update creating a pdb Task. * Address review comments. * Fixed for all cody-clark's review comments * Address review comments from mml * Address review comments from maisem * Fix missing backtick * Api and Kubectl reference docs updates for 1.7 (#4193) * Fix includes groups * Generated kubectl docs for 1.7 * Generated references docs for 1.7 api * Document node authorization mode * API Aggregator (#4173) * API Aggregator * Additional bullet points * incorporated feedback for apiserver-aggregation.md * split setup-api-aggregator.md into two docs and address feedback * fix link * addressed docs feedback * incorporate feedback * integrate feedback * Add documentation for DNS stub domains (#4063) * Add documentation for DNS stub domains * add additional prereq * fix image path * review feedback * minor grammar and style nits * documentation for using hostAliases to manage hosts file (#4080) * documentation for using hostAliases to manage hosts file * add to table of contents * review comments * update the right command to see hosts file * reformat doc based on suggestion and change some wording * Fix typo for #4080 * Patch PR #4063 * Fix wording in placement policy task introduction * Add update to statefulset concepts and basic tutorial (#4174) * Add update to statefulset concpets and basic tutorial * Address tech comments. * Update ESIPP docs for new added API fields * Custom resource docs * update audit document with advanced audit features added in 1.7 * kubeadm v1.7 documentation updates (#4018) * v1.7 updates for kubeadm * Address review comments * Address Luke's comments * Encrypting secrets at rest and cluster security guide * Edits for Custom DNS Documentation (#4207) * reorganize custom dns doc * format fixes * Update version numbers to 1.7 * Patch PR #4140 (#4215) * Patch PR #4140 * fix link and typos * Update PR template * Update TLS bootstrapping with 1.7 features This includes documenting the new CSR approver built into the controller manager and the kubelet alpha features for certificate rotation. Since the CSR approver changed over the 1.7 release cycle we need to call out the migration steps for those using the alpha feature. This document as a whole could probably use some updates, but the main focus of this PR is just to get these features minimally documented before the release. * Federated ClusterSelector formatting updates from review * complete PR #4181 (#4223) * complete PR #4181 * fix security link * Extensible admission controller (#4092) * extensible-admission-controllers * Update extensible-admission-controllers.md * more on initializers * fixes * Expand external admission webhooks documentation * wrap at 80 chars * more * add reference * Use correct apigroup for network policy * Docs changes to PR #4092 (#4224) * Docs changes to PR #4092 * address feedback * add doc for --as-group in cli Add doc for this pr: kubernetes/kubernetes#43696

The new format simply adds a prefix of "podpreset-" to the current annotation that records what presets have acted on a pod. The new naming makes it such that there is no chance of collision with the newly introduced opt-out annotation (or future ones yet to be added). Opt-out annotation PR: kubernetes/kubernetes#44965

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 26, 2017

k8s-github-robot assigned derekwaynecarr Apr 26, 2017

k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note-label-needed labels Apr 26, 2017

k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 8, 2017

k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 20, 2017

pmorie added this to the v1.7 milestone May 27, 2017

jpeeler changed the title ~~Allow pods to opt out of PodPreset mutation~~ Allow pods to opt out of PodPreset mutation via an annotation on the pod May 30, 2017

jpeeler force-pushed the podpreset-exclusion-simple branch from eb256fb to 16a87b9 Compare May 30, 2017 17:46

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 30, 2017

k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 30, 2017

derekwaynecarr assigned smarterclayton May 31, 2017

k8s-github-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-label-needed labels May 31, 2017

smarterclayton reviewed May 31, 2017

View reviewed changes

jpeeler force-pushed the podpreset-exclusion-simple branch from 16a87b9 to 4b5692d Compare May 31, 2017 19:28

derekwaynecarr reviewed May 31, 2017

View reviewed changes

jpeeler force-pushed the podpreset-exclusion-simple branch from 4b5692d to 2065ac7 Compare May 31, 2017 21:32

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 5, 2017

marun added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Jun 8, 2017

k8s-github-robot merged commit 9f23149 into kubernetes:master Jun 9, 2017

jpeeler mentioned this pull request Jun 13, 2017

Add documentation for podpreset opt-out annotation kubernetes/website#4067

Merged

jpeeler mentioned this pull request Jun 13, 2017

Update PodPreset modification annotation format kubernetes/community#716

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow pods to opt out of PodPreset mutation via an annotation on the pod #44965

Allow pods to opt out of PodPreset mutation via an annotation on the pod #44965

jpeeler commented Apr 26, 2017 •

edited by derekwaynecarr

Loading

k8s-reviewable commented Apr 26, 2017

k8s-ci-robot commented Apr 26, 2017

spiffxp commented May 8, 2017

pmorie commented May 27, 2017

pmorie commented May 27, 2017

smarterclayton May 31, 2017

jpeeler May 31, 2017

ncdc May 31, 2017

derekwaynecarr May 31, 2017

derekwaynecarr May 31, 2017

ncdc May 31, 2017

pmorie May 31, 2017

derekwaynecarr May 31, 2017

pmorie May 31, 2017

jpeeler May 31, 2017

derekwaynecarr commented May 31, 2017

derekwaynecarr commented May 31, 2017

pmorie commented May 31, 2017

jpeeler commented May 31, 2017

jpeeler commented May 31, 2017

derekwaynecarr May 31, 2017

derekwaynecarr May 31, 2017

derekwaynecarr May 31, 2017

derekwaynecarr commented May 31, 2017

derekwaynecarr commented Jun 5, 2017

k8s-github-robot commented Jun 5, 2017

k8s-ci-robot commented Jun 5, 2017 •

edited

Loading

derekwaynecarr commented Jun 9, 2017

k8s-github-robot commented Jun 9, 2017

derekwaynecarr commented Jun 9, 2017

Allow pods to opt out of PodPreset mutation via an annotation on the pod #44965

Allow pods to opt out of PodPreset mutation via an annotation on the pod #44965

Conversation

jpeeler commented Apr 26, 2017 • edited by derekwaynecarr Loading

k8s-reviewable commented Apr 26, 2017

k8s-ci-robot commented Apr 26, 2017

spiffxp commented May 8, 2017

pmorie commented May 27, 2017

pmorie commented May 27, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

derekwaynecarr commented May 31, 2017

derekwaynecarr commented May 31, 2017

pmorie commented May 31, 2017

jpeeler commented May 31, 2017

jpeeler commented May 31, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

derekwaynecarr commented May 31, 2017

derekwaynecarr commented Jun 5, 2017

k8s-github-robot commented Jun 5, 2017

k8s-ci-robot commented Jun 5, 2017 • edited Loading

derekwaynecarr commented Jun 9, 2017

k8s-github-robot commented Jun 9, 2017

derekwaynecarr commented Jun 9, 2017

jpeeler commented Apr 26, 2017 •

edited by derekwaynecarr

Loading

k8s-ci-robot commented Jun 5, 2017 •

edited

Loading