Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated NodeLegacyHostIP #44830

Merged
merged 1 commit into from
May 5, 2017
Merged

Remove deprecated NodeLegacyHostIP #44830

merged 1 commit into from
May 5, 2017

Conversation

NickrenREN
Copy link
Contributor

@NickrenREN NickrenREN commented Apr 24, 2017 •
edited by smarterclayton
Loading

Release note:

Remove deprecated node address type `NodeLegacyHostIP`.

ref #44807

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 24, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-github-robot k8s-github-robot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Apr 24, 2017
@NickrenREN NickrenREN changed the title Remove deprecated NodeLegacyHostIP [WIP] Remove deprecated NodeLegacyHostIP Apr 24, 2017
@caesarxuchao
Copy link
Member

The changes lgtm. @liggitt could you also take a look? Thanks.

@caesarxuchao
Copy link
Member

@NickrenREN why is the PR marked "WIP"?

@NickrenREN NickrenREN changed the title [WIP] Remove deprecated NodeLegacyHostIP Remove deprecated NodeLegacyHostIP Apr 26, 2017
@NickrenREN
Copy link
Contributor Author

NickrenREN commented Apr 26, 2017 •
edited
Loading

@caesarxuchao Sorry. I added 'WIP' at the beginning and forgot to remove it.
Removed

@liggitt
Copy link
Member

liggitt commented May 3, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 3, 2017
@NickrenREN
Copy link
Contributor Author

@k8s-bot kops aws e2e test this

@NickrenREN
Copy link
Contributor Author

@smarterclayton This pr needs your approval

@smarterclayton
Copy link
Contributor

/approve

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: NickrenREN, liggitt, smarterclayton

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 5, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 17d33ea into kubernetes:master May 5, 2017
@NickrenREN NickrenREN deleted the remove-NodeLegacyHostIP branch May 6, 2017 04:39
@0xmichalis 0xmichalis mentioned this pull request Jun 4, 2017
Closed
@lukaszo lukaszo mentioned this pull request Jun 5, 2017
Merged
k8s-github-robot pushed a commit that referenced this pull request Jun 14, 2017
Merge pull request #46960 from lukaszo/fedint
ce76bab 
Automatic merge from submit-queue

Add NodeInternalIP as a fallback to federation api-server nodeport service

Previously NodeLegacyHostIP was used as a fallback (see #41243) but in 1.7 it was removed (#44830)
Now clusters where nodes have not set ExternalIP can not be used by kubefed to setup federation.

cc @shashidharatd 

```release-note
kubefed will now configure NodeInternalIP as the federation API server endpoint when NodeExternalIP is unavailable for federation API servers exposed as NodePort services
```
deads2k added a commit to deads2k/origin that referenced this pull request Jul 7, 2017
@deads2k
DECARR: remove NodeLegacyHostIP per kubernetes/kubernetes#44830
f075ab2
deads2k added a commit to deads2k/origin that referenced this pull request Jul 7, 2017
@deads2k
DECARR: remove NodeLegacyHostIP per kubernetes/kubernetes#44830
dc717d2
deads2k added a commit to deads2k/origin that referenced this pull request Jul 10, 2017
@deads2k
DECARR: remove NodeLegacyHostIP per kubernetes/kubernetes#44830
f463030
deads2k added a commit to deads2k/origin that referenced this pull request Jul 11, 2017
@deads2k
DECARR: remove NodeLegacyHostIP per kubernetes/kubernetes#44830
8d4789b
deads2k added a commit to deads2k/origin that referenced this pull request Jul 12, 2017
@deads2k
DECARR: remove NodeLegacyHostIP per kubernetes/kubernetes#44830
446c52e
deads2k added a commit to deads2k/origin that referenced this pull request Jul 13, 2017
@deads2k
DECARR: remove NodeLegacyHostIP per kubernetes/kubernetes#44830
225549e
deads2k added a commit to deads2k/origin that referenced this pull request Jul 14, 2017
@deads2k
DECARR: remove NodeLegacyHostIP per kubernetes/kubernetes#44830
6541b7e
deads2k added a commit to deads2k/origin that referenced this pull request Jul 14, 2017
@deads2k
SJENNINGS: remove NodeLegacyHostIP per kubernetes/kubernetes#44830
bb3ee54
deads2k added a commit to deads2k/origin that referenced this pull request Jul 14, 2017
@deads2k
remove NodeLegacyHostIP per kubernetes/kubernetes#44830
245990e
deads2k added a commit to deads2k/origin that referenced this pull request Jul 17, 2017
@deads2k
remove NodeLegacyHostIP per kubernetes/kubernetes#44830
fe0c75a
deads2k added a commit to deads2k/origin that referenced this pull request Jul 17, 2017
@deads2k
remove NodeLegacyHostIP per kubernetes/kubernetes#44830
a19b648
deads2k added a commit to deads2k/origin that referenced this pull request Jul 18, 2017
@deads2k
remove NodeLegacyHostIP per kubernetes/kubernetes#44830
575a91f
@alena1108 alena1108 mentioned this pull request Aug 2, 2017
Closed
@simonpasquier simonpasquier mentioned this pull request Jul 3, 2018
Merged
@danwinship danwinship mentioned this pull request Nov 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@NickrenREN @k8s-reviewable @caesarxuchao @liggitt @smarterclayton @k8s-github-robot @erictune @k8s-ci-robot