Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redis-proxy example #44801

Merged
merged 1 commit into from
Apr 23, 2017
Merged

Remove redis-proxy example #44801

merged 1 commit into from
Apr 23, 2017

Conversation

klausenbusk
Copy link
Contributor

The docker image is nowhere to be found, so lets remove it.
There have been a request for the Dockerfile here [1], but nobody
seems to care.

[1] #4914 (comment)

What this PR does / why we need it:
This PR remove a k8s manifest which use a image which source is nowhere to be found.

Remove redis-proxy.yaml sample, as the image is nowhere to be found.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 22, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

Hi @klausenbusk. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 22, 2017
@k8s-github-robot k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Apr 22, 2017
@stevenaldinger
Copy link

stevenaldinger commented Apr 22, 2017 •
edited
Loading

I was really confused by that file and the lack of mentioning it in the README. Is the proxy concept necessary or can we actually just delete it and create a service that talks directly to the redis servers?

EDIT: You guys should check out the pr for this instead. https://github.com/shouhong/kubernetes/tree/be268953f52a7dab11f05a166aa08500efd62ff2/examples/storage/redis

@thockin
Copy link
Member

thockin commented Apr 23, 2017

@k8s-bot ok to test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 23, 2017
@thockin
Copy link
Member

thockin commented Apr 23, 2017

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 23, 2017
@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 23, 2017
@klausenbusk
Copy link
Contributor Author

@k8s-bot unit test this

@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 23, 2017
@klausenbusk
Copy link
Contributor Author

Is the proxy concept necessary or can we actually just delete it and create a service that talks directly to the redis servers?

That depends. Dummy clients (without sentinel support) would require a proxy, but smarter Redis clients wouldn't.
https://github.com/enriclluelles/redis-sentinel-proxy could be used as a proxy, with a slight code change (resolve of the sentinel addr is currently only done at startup, which would cause problem if the sentinel service is reconfigured).

@k8s-github-robot k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 23, 2017
@klausenbusk
Copy link
Contributor Author

@k8s-bot unit test this

@klausenbusk
Remove redis-proxy example
eb882a3 
The docker image is nowhere to be found, so lets remove it.
There have been a request for the Dockerfile here [1], but nobody
seems to care.

redis-proxy is replaced with redis-master in test-cmd-util.sh, to
ensure that the tests still works.
The redis-proxy pod in test/fixtures/doc-yaml/user-guide/multi-pod.yaml
is replaced with valid-pod from test/fixtures/doc-yaml/admin/limitrange/valid-pod.yaml,
so redis-proxy is removed every where.

[1] #4914 (comment)
@klausenbusk
Copy link
Contributor Author

@k8s-bot unit test this

@klausenbusk
Copy link
Contributor Author

@thockin all CI lights are green. It required some tweaking of the tests to get CI to pass.

@thockin
Copy link
Member

thockin commented Apr 23, 2017

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 23, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: klausenbusk, thockin

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 1235365 into kubernetes:master Apr 23, 2017
@ahmetb ahmetb mentioned this pull request Jun 11, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@thockin thockin

@brendandburns brendandburns

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@klausenbusk @k8s-reviewable @k8s-ci-robot @stevenaldinger @thockin @k8s-github-robot @brendandburns