Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed fluentd-gcp manifest pod #44721

Merged
merged 1 commit into from
Apr 20, 2017
Merged

Removed fluentd-gcp manifest pod #44721

merged 1 commit into from
Apr 20, 2017

Conversation

piosz
Copy link
Member

@piosz piosz commented Apr 20, 2017 •
edited by roberthbailey
Loading 

Fluentd manifest pod is no longer created on non-registered master when creating clusters using kube-up.sh.

@piosz piosz added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Apr 20, 2017
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 20, 2017
@k8s-github-robot k8s-github-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Apr 20, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@roberthbailey
Copy link
Contributor

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 20, 2017
@piosz
Copy link
Member Author

piosz commented Apr 20, 2017

@ixdy @jbeda can you approve?

@ixdy
Copy link
Member

ixdy commented Apr 20, 2017

/approve

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ixdy, piosz, roberthbailey

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 20, 2017
@piosz
Copy link
Member Author

piosz commented Apr 20, 2017

@k8s-bot gce etcd3 e2e test this

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 42177, 42176, 44721)

@k8s-github-robot k8s-github-robot merged commit 6bf9f2f into kubernetes:master Apr 20, 2017
@crassirostris crassirostris mentioned this pull request Jul 5, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@roberthbailey roberthbailey

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@piosz @k8s-reviewable @roberthbailey @ixdy @k8s-github-robot @k8s-ci-robot