Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print conditions of RC/RS in 'kubectl describe' command #44710

Merged
merged 1 commit into from
Apr 21, 2017
Merged

Print conditions of RC/RS in 'kubectl describe' command #44710

merged 1 commit into from
Apr 21, 2017

Conversation

xiangpengzhao
Copy link
Contributor

@xiangpengzhao xiangpengzhao commented Apr 20, 2017 •
edited
Loading

What this PR does / why we need it:
If conditions of RC/RS exist, print them in 'kubectl describe' command.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

Print conditions of RC/RS in 'kubectl describe' command.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 20, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @xiangpengzhao. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 20, 2017
@k8s-github-robot k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-label-needed labels Apr 20, 2017
@xiangpengzhao xiangpengzhao mentioned this pull request Apr 20, 2017
Closed
@k8s-reviewable
Copy link

This change is Reviewable

@soltysh
Copy link
Contributor

soltysh commented Apr 20, 2017

/lgtm
@k8s-bot ok to test
@xiangpengzhao mind updating the release notes, this is changing kubectl output
@kubernetes/sig-cli-pr-reviews fyi

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 20, 2017
@k8s-github-robot k8s-github-robot added do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-label-needed labels Apr 20, 2017
@xiangpengzhao
Copy link
Contributor Author

@soltysh Thanks! Updated PR title as release note.

@smarterclayton
Copy link
Contributor

/approve

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 20, 2017
@smarterclayton smarterclayton removed approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Apr 20, 2017
@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 20, 2017
@smarterclayton
Copy link
Contributor

Actually, the position is wrong. We already display conditions below the pod template on deployments - these new additions should be consistent. Please ensure that conditions for all controllers are consistently placed.

@smarterclayton
Copy link
Contributor

Removing lgtm and approve.

@xiangpengzhao
Copy link
Contributor Author

@smarterclayton Thanks Clayton for pointing that out! I will be OOO for several days. I will fix it ASAP when I'm back to office.

One more thing, I find that many objects in the current describe.go don't have consistent fields of their conditions be printed. e.g.
pod:

w.Write(LEVEL_0, "Conditions:\n  Type\tStatus\n")

node:

w.Write(LEVEL_0, "Conditions:\n  Type\tStatus\tLastHeartbeatTime\tLastTransitionTime\tReason\tMessage\n")

deployment:

w.Write(LEVEL_0, "Conditions:\n  Type\tStatus\tReason\n")

We should make them display consistent fields. Either printing all of the fields of each object, or printing same fields, e.g. Type Status Reason Message, might be okay.

We might also want to display conditions for other objects, whose conditions are not displayed yet.

I'll work on this after we decide which way we want to display conditions. But I hope someone can review and merge my former cleanup PR #43947 first, since it would be painful to rebase if I work on the two PRs at the same time.

@xiangpengzhao xiangpengzhao force-pushed the describe-print-rc-rs-conditions branch from c552e61 to b577754 Compare April 21, 2017 02:54
@xiangpengzhao
Copy link
Contributor Author

Addressed Clayton's comment. My above comment #44710 (comment) needs more discussion.

@smarterclayton PTAL

@soltysh
Copy link
Contributor

soltysh commented Apr 21, 2017

Addressed Clayton's comment. My above comment #44710 (comment) needs more discussion.

Open a separate issue to discuss this topic and ping sig-cli

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 21, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smarterclayton, soltysh, xiangpengzhao

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@0xmichalis 0xmichalis removed the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Apr 21, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 8e3d32b into kubernetes:master Apr 21, 2017
@xiangpengzhao xiangpengzhao mentioned this pull request Apr 26, 2017
Closed
@xiangpengzhao xiangpengzhao deleted the describe-print-rc-rs-conditions branch May 2, 2017 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dims dims

@soltysh soltysh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@xiangpengzhao @k8s-ci-robot @k8s-reviewable @soltysh @smarterclayton @k8s-github-robot @dims @0xmichalis