Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ceph-secret type to kubernetes.io/rbd in kubernetes-master charm #44635

Merged
merged 1 commit into from
Apr 19, 2017
Merged

Fix ceph-secret type to kubernetes.io/rbd in kubernetes-master charm #44635

merged 1 commit into from
Apr 19, 2017

Conversation

Cynerva
Copy link
Contributor

@Cynerva Cynerva commented Apr 18, 2017

What this PR does / why we need it:

This fixes the type of the ceph-secret secret that's created by the kubernetes-master charm.

Without the kubernetes.io/rbd type, automatic provisioning of PVCs doesn't work.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

Fix ceph-secret type to kubernetes.io/rbd in kubernetes-master charm

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 18, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

Hi @Cynerva. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 18, 2017
@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Apr 18, 2017
@Cynerva
Copy link
Contributor Author

Cynerva commented Apr 18, 2017

/assign @chuckbutler

I believe you were around when our ceph operational code was originally added. Can you review this change?

@lazypower
Copy link
Contributor

This is +1 LGTM. I had no clue this was a schema type. looking at https://github.com/kubernetes/kubernetes/tree/master/examples/persistent-volume-provisioning i see this is clearly outlined. Thanks for the fix @Cynerva

@lazypower
Copy link
Contributor

/approve

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 18, 2017
@lazypower
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 18, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cynerva, chuckbutler

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@grodrigues3 grodrigues3 removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 18, 2017
@lazypower
Copy link
Contributor

@k8s-bot unit test this

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit daeac53 into kubernetes:master Apr 19, 2017
@Cynerva Cynerva deleted the gkk/ceph-secret-type branch April 19, 2017 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lazypower lazypower

@j3ffml j3ffml

@eparis eparis

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Cynerva @k8s-reviewable @k8s-ci-robot @lazypower @k8s-github-robot @j3ffml @grodrigues3 @eparis