Explicit namespace from kubeconfig should override in-cluster config #44570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
k8s-ci-robot
added
the
cncf-cla: yes
k8s-github-robot
added
size/S
k8s-github-robot
added
size/M
liggitt
assigned fabianofranz and smarterclayton and unassigned caesarxuchao and erictune
|
cc @kubernetes/sig-cli-pr-reviews |
liggitt
force-pushed
the
namespace-icc
branch
3 times, most recently
from
563a5ad
to
7841a4b
Compare
ncdc
reviewed
Apr 18, 2017
test/e2e/kubectl.go
Outdated
| tokenFile: /var/run/secrets/kubernetes.io/serviceaccount/token | ||
| `), os.FileMode(0755))) | ||
| framework.Logf("copying %s to the %s pod", iccOverride.Name(), simplePodName) | ||
| framework.RunKubectlOrDie("cp", iccOverride.Name(), ns+"/"+simplePodName+":/tmp/icc-override.kubeconfig") |
There was a problem hiding this comment.
I am not sure if this is a regression, but it appears you can't change the destination filename; i.e. kubectl cp sourcefile pod:/tmp/destfile will yield /tmp/sourcefile inside the container :-/ I discovered this a few days ago when testing something else.
There was a problem hiding this comment.
Here's an example of what it's running:
Running '/workspace/kubernetes/platforms/linux/amd64/kubectl --server=https://104.198.236.9 --kubeconfig=/workspace/.kube/config cp /tmp/icc-override.kubeconfig363380968 e2e-tests-kubectl-bp2b4/nginx:/tmp/icc-override.kubeconfig'
There was a problem hiding this comment.
huh... that's super-annoying
There was a problem hiding this comment.
@fraenkel, is this a known issue? ^
|
kubectl cp is really tar which makes anything difficult. To really do cp
we would need a helper on the server side which we don't have.
|
liggitt
added
release-note
|
updated test to match kubeconfig filenames |
|
tests green, PTAL |
13 tasks
| } | ||
|
|
||
| // if we got a default namespace, determine whether it was explicit or implicit | ||
| if raw, err := mergedKubeConfig.RawConfig(); err == nil { |
There was a problem hiding this comment.
When the Kubeconfig revolution comes, this method will be first up against the wall. But the tests are convincing
|
/approve |
k8s-github-robot
added
the
approved
k8s-github-robot
pushed a commit
that referenced
this pull request
Apr 25, 2017
…#44862-upstream-release-1.6 Automatic merge from submit-queue Automated cherry pick of #44570 #44862 Cherry pick of #44570 #44862 on release-1.6. #44570: Explicit namespace from kubeconfig should override in-cluster #44862: Stop treating in-cluster-config namespace as an override ```release-note * kubectl commands run inside a pod using a kubeconfig file now use the namespace specified in the kubeconfig file, instead of using the pod namespace. If no kubeconfig file is used, or the kubeconfig does not specify a namespace, the pod namespace is still used as a fallback. * Restored the ability of kubectl running inside a pod to consume resource files specifying a different namespace than the one the pod is running in. ```
|
Commit found in the "release-1.6" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked. |
This was referenced May 21, 2021
Closed
This was referenced May 30, 2021
This was referenced Jun 6, 2021
This was referenced Jun 14, 2021
1 task
This was referenced Jul 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #43662
If an explicitly specified namespace is read from a kubeconfig file, we should not fall back to in-cluster config