Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Kubernetes 1.6 support to Juju charms #44500

Merged
merged 10 commits into from
Apr 18, 2017
Merged

Add Kubernetes 1.6 support to Juju charms #44500

merged 10 commits into from
Apr 18, 2017

Conversation

Cynerva
Copy link
Contributor

@Cynerva Cynerva commented Apr 14, 2017 •
edited
Loading

What this PR does / why we need it:

This adds Kubernetes 1.6 support to Juju charms.

This includes some large architectural changes in order to support multiple versions of Kubernetes with a single release of the charms. There are a few bug fixes in here as well, for issues that we discovered during testing.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Thanks to @marcoceppi, @ktsakalozos, @jacekn, @mbruzek, @tvansteenburgh for their work in this feature branch as well!

Release note:

Add Kubernetes 1.6 support to Juju charms
Add metric collection to charms for autoscaling
Update kubernetes-e2e charm to fail when test suite fails
Update Juju charms to use snaps
Add registry action to the kubernetes-worker charm
Add support for kube-proxy cluster-cidr option to kubernetes-worker charm
Fix kubernetes-master charm starting services before TLS certs are saved
Fix kubernetes-worker charm failures in LXD
Fix stop hook failure on kubernetes-worker charm
Fix handling of juju kubernetes-worker.restart-needed state
Fix nagios checks in charms

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 14, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @Cynerva. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 14, 2017
@k8s-github-robot k8s-github-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Apr 14, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@marcoceppi
Copy link
Contributor

@k8s-bot ok to test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 14, 2017
@marcoceppi
Copy link
Contributor

/approve

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 14, 2017
@Cynerva
Copy link
Contributor Author

Cynerva commented Apr 14, 2017

/assign @marcoceppi

@marcoceppi
Copy link
Contributor

@k8s-bot verify test this

@k8s-github-robot k8s-github-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 14, 2017
@Cynerva
Copy link
Contributor Author

Cynerva commented Apr 14, 2017

Pushed updates to hacks/verify-flags/exceptions.txt to cover the new stuff in kubernetes_worker.py.

@marcoceppi
Copy link
Contributor

/approve

@marcoceppi
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 14, 2017
@marcoceppi marcoceppi mentioned this pull request Apr 14, 2017
Closed
This was referenced Apr 17, 2017
Closed
Closed
@lazypower
Copy link
Contributor

@smarterclayton @liggitt Could either of you two take a quick look at this PR? It seems that the k8s bot didn't tag anyone from the owners file of the HACK dir which is holding things up here as we're pending a /approve /lgtm.

@lazypower
Copy link
Contributor

@k8s-bot non-cri e2e test this

@liggitt
Copy link
Member

liggitt commented Apr 18, 2017

/approve verify-flags changes

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cynerva, liggitt, marcoceppi

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 18, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 43000, 44500, 44457, 44553, 44267)

@k8s-github-robot k8s-github-robot merged commit 09e3fdb into kubernetes:master Apr 18, 2017
@Cynerva Cynerva mentioned this pull request Apr 19, 2017
Closed
@Cynerva Cynerva deleted the gkk/cdk-1.6-support branch April 19, 2017 18:41
@Cynerva Cynerva mentioned this pull request Jun 14, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@marcoceppi marcoceppi

@thockin thockin

@nikhiljindal nikhiljindal

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.