Drop leading path of KUBECTL.EXE if it shows up in User-Agent. #44421
+13
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
This change is |
k8s-github-robot
added
size/S
mml
added
release-note
Contributor
Author
|
@k8s-bot unit test this |
Contributor
|
/lgtm |
k8s-ci-robot
added
the
lgtm
k8s-github-robot
added
the
approved
|
Automatic merge from submit-queue (batch tested with PRs 44362, 44421, 44468, 43878, 44480) |
enisoc
reviewed
Apr 14, 2017
| } | ||
| // If an old "kubectl.exe" has passed us its full path, we discard the path portion. | ||
| if exeIdx := strings.LastIndex(strings.ToLower(ua), "kubectl.exe"); exeIdx != -1 { | ||
| return ua[exeIdx:] |
Contributor
There was a problem hiding this comment.
This can panic based on user input since strings.ToLower(ua) is not necessarily the same length in bytes as ua:
mml
added a commit
to mml/kubernetes
that referenced
this pull request
Apr 17, 2017
Backport of kubernetes#44421 kubernetes#44513 on release-1.5.
mml
added a commit
to mml/kubernetes
that referenced
this pull request
Apr 18, 2017
Backport of kubernetes#44421 kubernetes#44513 on release-1.4.
k8s-github-robot
pushed a commit
that referenced
this pull request
Apr 21, 2017
Automatic merge from submit-queue Backport of #44421 #44513 Backport of #44421 #44513 on release-1.5. #44421: Drop leading path of KUBECTL.EXE if it shows up in #44513: Use regexp instead of substring to do search and replace. ```release-note kube-apiserver now drops unneeded path information if an older version of Windows kubectl sends it. ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial fix for #44419