Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

delete ubuntu kube-up #44344

Merged
merged 1 commit into from
Apr 15, 2017
Merged

delete ubuntu kube-up #44344

merged 1 commit into from
Apr 15, 2017

Conversation

mikedanese
Copy link
Member 

Remove deprecated ubuntu kube-up deployment.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 11, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-github-robot k8s-github-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Apr 11, 2017
resouer
resouer reviewed Apr 12, 2017
View reviewed changes
Copy link
Contributor

@resouer resouer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Must update this doc: https://kubernetes.io/docs/setup/pick-right-solution/

@resouer resouer mentioned this pull request Apr 14, 2017
Closed
@ixdy ixdy mentioned this pull request Apr 14, 2017
Closed
@mikedanese mikedanese assigned roberthbailey and unassigned zmerlynn and eparis Apr 14, 2017
@roberthbailey
Copy link
Contributor

@resouer - we'll need to upgrade that guide in a separate PR since it's in a different repo.
@mikedanese - please send a follow up PR to fix the getting started guides.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 15, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikedanese, roberthbailey

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 44343, 44344)

@k8s-github-robot k8s-github-robot merged commit b22a298 into kubernetes:master Apr 15, 2017
@k8s-ci-robot
Copy link
Contributor

@mikedanese: The following test(s) failed:

Test name Commit Details Rerun command
Jenkins GCE etcd3 e2e e8a3e2d link @k8s-bot gce etcd3 e2e test this

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@xiangpengzhao xiangpengzhao mentioned this pull request Apr 24, 2017
Closed
This was referenced Apr 25, 2017
Closed
Closed
Closed
Closed
Closed
Closed
@mikedanese mikedanese deleted the ubuntu-delete branch June 28, 2017 21:00
@A-j-K
Copy link

A-j-K commented Jul 14, 2017

You might like to update the online documentation when you pull major parts like this, save us wasting a morning

https://kubernetes.io/docs/getting-started-guides/ubuntu/manual/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@resouer resouer resouer left review comments

Assignees

@roberthbailey roberthbailey

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@mikedanese @k8s-reviewable @roberthbailey @k8s-github-robot @k8s-ci-robot @A-j-K @resouer @zmerlynn @eparis