Zero-out healthchecks when no endpoints #44313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
This change is |
thockin
added
the
release-note-none
k8s-github-robot
added
approved
thockin
added
area/kube-proxy
and removed
approved
k8s-github-robot
added
approved
MrHohn
approved these changes
Apr 11, 2017
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MrHohn, thockin
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
I am looking at patching this into 1.6 now
…On Mon, Apr 10, 2017 at 9:54 PM, Kubernetes Submit Queue < ***@***.***> wrote:
[APPROVALNOTIFIER] This PR is *APPROVED*
This pull-request has been approved by: *MrHohn
<#44313 (comment)>*,
*thockin <#44313#>*
Needs approval from an approver in each of these OWNERS Files:
- pkg/proxy/OWNERS
<https://github.com/kubernetes/kubernetes/blob/master/pkg/proxy/OWNERS>
[thockin]
You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#44313 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFVgVO-oWfCpM0JqpEdq4eLIGgc9nlfYks5ruwejgaJpZM4M5nVr>
.
|
|
Automatic merge from submit-queue |
k8s-github-robot
pushed a commit
that referenced
this pull request
Apr 12, 2017
…#44313-upstream-release-1.6 Automatic merge from submit-queue Automated cherry pick of #44053 #44313 Cherry pick of #44053 #44313 on release-1.6. #44053: Add tests for kube-proxy healthcheck, fix bug #44313: Zero-out healthchecks when no endpoints ```release-note Fix corner-case with OnlyLocal Service healthchecks ```
enisoc
added
release-note
mintzhao
pushed a commit
to mintzhao/kubernetes
that referenced
this pull request
Jun 1, 2017
…k-of-#44053-kubernetes#44313-upstream-release-1.6 Automatic merge from submit-queue Automated cherry pick of kubernetes#44053 kubernetes#44313 Cherry pick of kubernetes#44053 kubernetes#44313 on release-1.6. kubernetes#44053: Add tests for kube-proxy healthcheck, fix bug kubernetes#44313: Zero-out healthchecks when no endpoints ```release-note Fix corner-case with OnlyLocal Service healthchecks ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #44311