Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Federation] Remove deprecated federation-apiserver-kubeconfig secret #44287

Merged
merged 2 commits into from
Apr 10, 2017
Merged

[Federation] Remove deprecated federation-apiserver-kubeconfig secret #44287

merged 2 commits into from
Apr 10, 2017

Conversation

shashidharatd
Copy link

@shashidharatd shashidharatd commented Apr 10, 2017 •
edited
Loading

federation-apiserver-kubeconfig was deprecated and was supposed to be removed in 1.6.
Removing all references to it as we no longer use it.

Release note:

[Federation] Deprecated `federation-apiserver-kubeconfig` is not supported anymore. Should use `--kubeconfig` flag to specify Federation API server kubeconfig.

cc @kubernetes/sig-federation-pr-reviews

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 10, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-github-robot k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note-label-needed labels Apr 10, 2017
@shashidharatd
Copy link
Author

/assign @madhusudancs

@madhusudancs
Copy link
Contributor

/lgtm
/approve

Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 10, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: madhusudancs, shashidharatd

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels Apr 10, 2017
@madhusudancs
Copy link
Contributor

@shashidharatd can we add a release note here saying we don't support the old secret name anymore?

@madhusudancs madhusudancs added this to the v1.7 milestone Apr 10, 2017
@k8s-github-robot k8s-github-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-label-needed labels Apr 10, 2017
@shashidharatd
Copy link
Author

@madhusudancs, release note is added now. PTAL.
Thanks

@madhusudancs madhusudancs removed the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Apr 10, 2017
@madhusudancs
Copy link
Contributor

@shashidharatd looks good. Thanks.

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 43273, 44287, 44281)

@k8s-github-robot k8s-github-robot merged commit 478f469 into kubernetes:master Apr 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@madhusudancs madhusudancs

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.
5 participants
@shashidharatd @k8s-reviewable @madhusudancs @k8s-github-robot @k8s-ci-robot