Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add namespace-{list, create, delete} actions to the kubernetes-master layer #44277

Merged
merged 1 commit into from
Apr 25, 2017
Merged

Add namespace-{list, create, delete} actions to the kubernetes-master layer #44277

merged 1 commit into from
Apr 25, 2017

Conversation

jacekn
Copy link

@jacekn jacekn commented Apr 10, 2017

What this PR does / why we need it:

This PR adds namespace-{list,create,delete} actions to the juju kubernetes-master layer.

Which issue this PR fixes: fixes #43712

Special notes for your reviewer:

Original PR juju-solutions#109

Release note:

Add  namespace-{list,create,delete} actions to the juju kubernetes-master layer

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 10, 2017
@k8s-github-robot k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Apr 10, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

Hi @jacekn. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@thockin
Copy link
Member

thockin commented Apr 25, 2017

@k8s-bot ok to test

@thockin
Copy link
Member

thockin commented Apr 25, 2017

tag me when LGTM

@mbruzek
Copy link
Contributor

mbruzek commented Apr 25, 2017 •
edited
Loading

Yes this code looks valid. The tests are passing.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 25, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jacekn, mbruzek

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 25, 2017
@mbruzek
Copy link
Contributor

mbruzek commented Apr 25, 2017

/assign @thockin

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 40d5146 into kubernetes:master Apr 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@thockin thockin

@mbruzek mbruzek

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add namespace management actions to kubernetes-master juju layer
6 participants
@jacekn @k8s-reviewable @k8s-ci-robot @thockin @mbruzek @k8s-github-robot