[Federation] Use cascading deletion when deleting resources in underlying clusters #44108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Federation control plane issues a delete command unless it wants to orphan the underlying per-cluster resource. When issuing that command, always set the orphanDependents to false.
k8s-ci-robot
added
cncf-cla: yes
k8s-github-robot
added
approved
|
/release-note-none |
k8s-ci-robot
added
release-note-none
|
This change is |
|
Thanks lgtm. I wasnt expecting the kubefed change, but should be fine. I can cherrypick this with my PR. Will also run e2e once to make sure that its WAI :) |
nikhiljindal
changed the title
|
Verified that e2e tests pass with this change. /lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: csbell, nikhiljindal
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue |
This was referenced Apr 10, 2017
|
Commit found in the "release-1.6" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked. |
enisoc
added
release-note
mintzhao
pushed a commit
to mintzhao/kubernetes
that referenced
this pull request
Jun 1, 2017
…y-pick-of-#44108-upstream-release-1.6 Automatic merge from submit-queue Automated cherry pick of kubernetes#44108 Cherry pick of kubernetes#44108 on release-1.6. kubernetes#44108: fed: Disable orphaning of per-cluster resources on deletion. ```release-note Fix for [federation failing to propagate cascading deletion](kubernetes#44304). ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Federation control plane issues a delete command unless it wants to orphan the underlying per-cluster resource. When issuing that command, always set the orphanDependents to false.
/release-note-none
/sig-federation