Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove alphaProvisioner in PVController and AlphaStorageClassAnnotation #44090

Merged
merged 1 commit into from
Apr 12, 2017
Merged

Remove alphaProvisioner in PVController and AlphaStorageClassAnnotation #44090

merged 1 commit into from
Apr 12, 2017

Conversation

NickrenREN
Copy link
Contributor

@NickrenREN NickrenREN commented Apr 5, 2017 •
edited
Loading

remove alpha annotation and alphaProvisioner

Release note:

alpha volume provisioning is removed and default storage class should be used instead.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 5, 2017
@k8s-github-robot k8s-github-robot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. labels Apr 5, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@NickrenREN
Copy link
Contributor Author

/assign @jsafrane

@pwittrock pwittrock removed their assignment Apr 5, 2017
@pwittrock
Copy link
Member

Not sure why I was assigned this PR

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 7, 2017
@k8s-github-robot k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 10, 2017
@NickrenREN
Copy link
Contributor Author

NickrenREN commented Apr 10, 2017 •
edited
Loading

kindly ping @jsafrane . Could you help to take a look ? Thanks

@jsafrane
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 10, 2017
@jsafrane
Copy link
Member

Thanks for the PR!

@jsafrane
Copy link
Member

@thockin, PTAL and approve

@NickrenREN
Copy link
Contributor Author

/assign @thockin

@thockin
Copy link
Member

thockin commented Apr 12, 2017

/approve

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: NickrenREN, jsafrane, thockin

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 12, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit e60cc6e into kubernetes:master Apr 12, 2017
@NickrenREN NickrenREN deleted the remove-alpha-pv branch April 12, 2017 04:23
@jsafrane
Copy link
Member

@NickrenREN, this needs a release note.

@NickrenREN
Copy link
Contributor Author

/release-note

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Apr 12, 2017
@k8s-ci-robot k8s-ci-robot removed the release-note-none Denotes a PR that doesn't merit a release note. label Apr 12, 2017
@jsafrane jsafrane mentioned this pull request May 23, 2017
Closed
@sttts sttts mentioned this pull request Jul 17, 2017
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jsafrane jsafrane

@thockin thockin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@NickrenREN @k8s-reviewable @pwittrock @jsafrane @thockin @k8s-github-robot @k8s-ci-robot