Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubeadm: clean up exited containers and network checkpoints #43836

Merged
merged 1 commit into from
Mar 30, 2017
Merged

kubeadm: clean up exited containers and network checkpoints #43836

merged 1 commit into from
Mar 30, 2017

Conversation

yujuhong
Copy link
Contributor

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 30, 2017
@k8s-github-robot k8s-github-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 30, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@yujuhong
Copy link
Contributor Author

Not very important, but just some extra cleanup.

By the way, the cleanup logic heavily depends on kubelet's internal implementation. I'd suggest moving away from that in the future if possible (yes, I know it's not easy...).

/cc @jbeda @mikedanese

@mikedanese mikedanese assigned mikedanese and unassigned luxas Mar 30, 2017
@mikedanese mikedanese added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Mar 30, 2017
@mikedanese
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 30, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikedanese, yujuhong

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 30, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 43508, 43836)

@k8s-github-robot k8s-github-robot merged commit 58d2d9a into kubernetes:master Mar 30, 2017
@luxas
Copy link
Member

luxas commented Mar 31, 2017

@yujuhong Cool, thanks. I noticed this issue yesterday during KubeCon when the kubelet started reporting unready status some mins after init after not being able to delete old networks that don't exist anymore. Not sure if that's a bug or feature.

However, for kubeadm this patch is critical for v1.6.1, can you make a cherrypick ASAP, please?

@yujuhong
Copy link
Contributor Author

kubelet started reporting unready status some mins after init after not being able to delete old networks that don't exist anymore

I don't think this should happen. kubelet shouldn't become unready just because some pods/containers can't be cleanup. If you can reproduce it, feel free to file a bug.

I won't say this PR is critical, but it's always good to make sure you have a clean slate after running reset. I'll make a cherrypick PR.

@yujuhong yujuhong added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Mar 31, 2017
@yujuhong yujuhong added this to the v1.6 milestone Mar 31, 2017
@yujuhong yujuhong mentioned this pull request Mar 31, 2017
Merged
k8s-github-robot pushed a commit that referenced this pull request Apr 12, 2017
Merge pull request #43917 from yujuhong/automated-cherry-pick-of-#438…
28e22ea 
…36-upstream-release-1.6

Automatic merge from submit-queue

Automated cherry pick of #43836

Cherry pick of #43836 on release-1.6.

#43836: kubeadm: clean up exited containers and network checkpoints
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.6" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

@yujuhong yujuhong deleted the kubeadm-cleanup branch May 19, 2017 16:57
mintzhao pushed a commit to mintzhao/kubernetes that referenced this pull request Jun 1, 2017
Merge pull request kubernetes#43917 from yujuhong/automated-cherry-pi…
71286e7 
…ck-of-#43836-upstream-release-1.6

Automatic merge from submit-queue

Automated cherry pick of kubernetes#43836

Cherry pick of kubernetes#43836 on release-1.6.

kubernetes#43836: kubeadm: clean up exited containers and network checkpoints
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mikedanese mikedanese

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.6
Development

Successfully merging this pull request may close these issues.
7 participants
@yujuhong @k8s-reviewable @mikedanese @k8s-github-robot @luxas @k8s-cherrypick-bot @k8s-ci-robot