Make RBAC post-start hook conditional on RBAC authorizer being used #43813
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
This change is |
k8s-github-robot
added
the
size/M
|
cc @kubernetes/sig-auth-pr-reviews |
k8s-github-robot
added
release-note-label-needed
release-note
|
I'm not an approver, but seems reasonable to me. |
liggitt
force-pushed
the
conditional-post-start-hook
branch
from
21b1a58
to
552c3d3
Compare
|
Seems like it would be better to provide a generic way to skip a poststarthook (they're already named) and drive that instead. |
liggitt
force-pushed
the
conditional-post-start-hook
branch
from
552c3d3
to
259ae0e
Compare
Done, PTAL |
liggitt
force-pushed
the
conditional-post-start-hook
branch
from
259ae0e
to
890894a
Compare
|
/lgtm |
k8s-ci-robot
added
release-note-none
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, liggitt
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
k8s-github-robot
added
the
approved
|
Automatic merge from submit-queue |
|
@liggitt: The following test(s) failed:
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
liggitt
added
release-note
…3-upstream-release-1.6 Automatic merge from submit-queue Automated cherry pick of #43813 Cherry pick of #43813 on release-1.6. #43813: Allow disabling specific post-start hooks Avoids populating RBAC objects if the RBAC authorizer is not being used ```release-note RBAC role and rolebinding auto-reconciliation is now performed only when the RBAC authorization mode is enabled. ```
|
Commit found in the "release-1.6" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked. |
…k-of-#43813-upstream-release-1.6 Automatic merge from submit-queue Automated cherry pick of kubernetes#43813 Cherry pick of kubernetes#43813 on release-1.6. kubernetes#43813: Allow disabling specific post-start hooks Avoids populating RBAC objects if the RBAC authorizer is not being used ```release-note RBAC role and rolebinding auto-reconciliation is now performed only when the RBAC authorization mode is enabled. ```
Makes the RBAC post-start hook (and reconciliation) conditional on the RBAC authorizer being used
Ensures we don't set up unnecessary objects.