Skip to content

Fix #43583 (kubenet: remove code forcing bridge MAC address) #43661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-github-robot merged 1 commit into from
Oct 18, 2017
Merged

Fix #43583 (kubenet: remove code forcing bridge MAC address) #43661

k8s-github-robot merged 1 commit into from
Oct 18, 2017
+7 −73

Conversation

@xiangpengzhao
Copy link
Contributor

@xiangpengzhao xiangpengzhao commented Mar 25, 2017

What this PR does / why we need it:
kubenet: remove code forcing bridge MAC address

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #43583

Special notes for your reviewer:

Release note:

cc @dcbw @freehan

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 25, 2017
@k8s-github-robot k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note-label-needed labels Mar 25, 2017
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 25, 2017

Hi @xiangpengzhao. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-reviewable
Copy link

k8s-reviewable commented Mar 25, 2017

This change is Reviewable

@xiangpengzhao xiangpengzhao mentioned this pull request Mar 25, 2017
Closed
@MrHohn
Copy link
Member

MrHohn commented Mar 27, 2017

/assign @dcbw
/assign @freehan
/unassign

@k8s-ci-robot k8s-ci-robot assigned dcbw and freehan and unassigned MrHohn Mar 27, 2017
@freehan
Copy link
Contributor

freehan commented Apr 4, 2017

Thanks for the PR. will LGTM this once cni binary are bumped.

@grodrigues3 grodrigues3 added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 5, 2017
@dcbw
Copy link
Contributor

dcbw commented Apr 6, 2017

LGTM once we bump the binaries; @squeed has a PR to do that already for some other reasons.

But once we get @Sqeed's PR we can get rid of the LinkByName() code plugin.syncEbtablesDedupRules(link.Attrs().HardwareAddr) and pull the bridge hardware address out of the CNI Result structure.

@xiangpengzhao
Copy link
Contributor Author

xiangpengzhao commented Apr 16, 2017

@freehan @dcbw Thanks !

@spiffxp
Copy link
Contributor

spiffxp commented May 8, 2017

@k8s-bot ok to test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 8, 2017
@dcbw dcbw added the sig/network Categorizes an issue or PR as relevant to SIG Network. label May 23, 2017
@spiffxp
Copy link
Contributor

spiffxp commented Jun 15, 2017

/retest

@xiangpengzhao
Copy link
Contributor Author

xiangpengzhao commented Aug 24, 2017

@dcbw any updates on bumping the binaries?

@k8s-github-robot
Copy link

k8s-github-robot commented Aug 30, 2017

Adding do-not-merge/release-note-label-needed because the release note process has not been followed.
One of the following labels is required "release-note", "release-note-action-required", "release-note-experimental" or "release-note-none".
Please see: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#write-release-notes-if-needed.

@k8s-github-robot k8s-github-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Aug 30, 2017
@xiangpengzhao
Copy link
Contributor Author

xiangpengzhao commented Sep 23, 2017

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 23, 2017
@freehan
Copy link
Contributor

freehan commented Oct 18, 2017

#51250 is merged

/retest
/lgtm
/apprve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 18, 2017
@k8s-github-robot
Copy link

k8s-github-robot commented Oct 18, 2017

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: freehan, xiangpengzhao

Associated issue: 43583

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 18, 2017
@k8s-github-robot
Copy link

k8s-github-robot commented Oct 18, 2017

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

k8s-github-robot commented Oct 18, 2017

Automatic merge from submit-queue (batch tested with PRs 43661, 54062). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 257b6f3 into kubernetes:master Oct 18, 2017
@xiangpengzhao xiangpengzhao deleted the revert-genmac branch October 18, 2017 20:27
@leblancd leblancd mentioned this pull request Oct 19, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@freehan freehan

@dcbw dcbw

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/network Categorizes an issue or PR as relevant to SIG Network. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

kubenet: remove code forcing bridge MAC address

9 participants

@xiangpengzhao @k8s-ci-robot @k8s-reviewable @MrHohn @freehan @dcbw @spiffxp @k8s-github-robot @grodrigues3