This change is 

Reviewed 15 of 15 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.

cluster/common.sh, line 873 at r1 (raw file):

EOF
  fi
  if [ -n "${FEDERATIONS_DOMAIN_MAP:-}" ]; then

Removes the if without removing the corresponding fi.

Comments from Reviewable

Thanks for removing this.

Review status: 14 of 15 files reviewed at latest revision, 1 unresolved discussion.

cluster/common.sh, line 873 at r1 (raw file):

missed it :) thanks madhu, fixed it now

Comments from Reviewable

/lgtm
/approve

@shashidharatd this is a user facing change. You might need a release note.

/approve

Release note:

[Federation] Mechanism of adding `federation domain maps` to kube-dns deployment via `--federations` flag is superseded by adding/updating `federations` key in `kube-system/kube-dns` configmap. If user is using kubefed tool to join cluster federation, adding federation domain maps to kube-dns is already taken care by `kubefed join` and does not need further action.

@shashidharatd I thought that the bot read the release notes only from the PR description. Do you know for sure that the bot can read the release notes from other comments as well?

@madhusudancs, i thought it might read it, but it didn't :) added now in PR description. is the release notes explanation good enough?

@shashidharatd yeah the note looks good.

Thanks for moving it to the PR description.

Thanks @madhusudancs, can you please remove do-not-merge label?
Also request an lgtm from @jbeda

/approve

@jbeda, request an approve label for "hack" related changes.

@jbeda seems busy, @fejta can you please approve this for hack

@k8s-bot non-cri e2e test this

/lgtm

Sorry for the delay.

Please /assign @fejta whenever you want my attention. I depend on the PR dashboard to tell me when/where my attention is needed.

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fejta, madhusudancs, mikedanese, shashidharatd

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

Automatic merge from submit-queue