Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow minion floating IPs to be optional #42638

Merged
merged 1 commit into from
Mar 26, 2017
Merged

Allow minion floating IPs to be optional #42638

merged 1 commit into from
Mar 26, 2017

Conversation

jamiehannaford
Copy link
Contributor

What this PR does / why we need it:

Makes the generation of floating IPs for worker nodes optional, based on an env var. To quote the original issue:

Currently, the OpenStack installation method assigns a floating IP to every single worker node. While this is fine for smaller clusters with a good sized IP pool, it can cause issues in environments with high node counts or less IPs available.

Which issue this PR fixes:

#40737

Special notes for your reviewer:

I used the conditions section of the Heat spec: https://docs.openstack.org/developer/heat/template_guide/hot_spec.html#conditions-section

Release note:

OpenStack clusters can now specify whether worker nodes are assigned a floating IP

@k8s-ci-robot
Copy link
Contributor

Hi @jamiehannaford. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 7, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-github-robot k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Mar 7, 2017
@eparis
Copy link
Contributor

eparis commented Mar 8, 2017

@k8s-bot test this
@k8s-sig-openstack-pr-reviews I know hot to spell heat, and not much more. Anyone on the OpenStack sig willing to take this review?

@eparis eparis added the area/provider/openstack Issues or PRs related to openstack provider label Mar 8, 2017
@hogepodge
Copy link

Nothing jumps out as incorrect in this template. It addresses a second major mode of network connectivity in OpenStack deployments.

@jamiehannaford
Copy link
Contributor Author

@eparis @hogepodge Do I need to incorporate anything else or is this approved?

@eparis
Copy link
Contributor

eparis commented Mar 14, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 14, 2017
@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 14, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

The following people have approved this PR: eparis, jamiehannaford

Needs approval from an approver in each of these OWNERS Files:

We suggest the following people:
cc @roberthbailey
You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 25, 2017
@fejta fejta removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 25, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 41297, 42638, 42666, 43039, 42567)

@k8s-github-robot k8s-github-robot merged commit e6453c7 into kubernetes:master Mar 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@eparis eparis

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/openstack Issues or PRs related to openstack provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jamiehannaford @k8s-ci-robot @k8s-reviewable @eparis @hogepodge @k8s-github-robot @fejta