Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get-kube-local.sh checks pods with option "--namespace=kube-system" #42518

Merged
merged 1 commit into from
Apr 4, 2017
Merged

get-kube-local.sh checks pods with option "--namespace=kube-system" #42518

merged 1 commit into from
Apr 4, 2017

Conversation

mtanino
Copy link

@mtanino mtanino commented Mar 4, 2017 •
edited
Loading

What this PR does / why we need it:

Local cluster creation using get-kube-local.sh is never finished.
The get-kube-local.sh monitors running_count of pods such as etcd,
master and kube-proxy, but these pods are created under the namespace
kube-system. Therefore kubectl can't find these pods then cluster
creation isn't completed.

The get-kube-local.sh should monitor created pods with option
"--namespace=kube-system".

Which issue this PR fixes : fixes #42517

Release note:

`NONE`

@k8s-ci-robot
Copy link
Contributor

Hi @mtanino. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

Once you've signed, please reply here (e.g. "I signed it!") and we'll verify. Thanks.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Mar 4, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Mar 4, 2017
get-kube-local.sh checks pods with option "--namespace=kube-system"
fe5f7a7 
Local cluster creation using get-kube-local.sh is never finished.
The get-kube-local.sh monitors running_count of pods such as etcd,
master and kube-proxy, but these pods are created under the namespace
kube-system. Therefore kubectl can't find these pods then cluster
creation isn't completed.

The get-kube-local.sh should monitor created pods with option
"--namespace=kube-system".

Fix kubernetes#42517
@mtanino mtanino closed this Mar 4, 2017
@mtanino mtanino deleted the issue/42517 branch March 4, 2017 05:21
@mtanino mtanino restored the issue/42517 branch March 4, 2017 05:22
@mtanino mtanino reopened this Mar 4, 2017
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 4, 2017
@mtanino
Copy link
Author

mtanino commented Mar 4, 2017

cc @mikedanese

@k8s-github-robot k8s-github-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-label-needed labels Mar 6, 2017
@roberthbailey
Copy link
Contributor

/lgtm /approve

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

The following people have approved this PR: mtanino, roberthbailey

Needs approval from an approver in each of these OWNERS Files:

We suggest the following people:
cc @mikedanese
You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 7, 2017
@mtanino
Copy link
Author

mtanino commented Mar 8, 2017

@roberthbailey

Hi, Thank you for your review.
I'm new to Kubernetes community. In this case, does this PR need "ok-to-merge" label to get merged?

https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md
Additionally, for infrequent or new contributors, we require the on call to apply the "ok-to-merge" label manually. This is gated by the whitelist.

Thanks,
Mitsuhiro Tanino

@roberthbailey
Copy link
Contributor

I'm not sure if that comment is still applicable. As we are in the code slush for the 1.6 release, the mergebot is currently only merging PRs with the 1.6 milestone applied. If this is a bug fix that should be part of that release, please ask @calebamiles to apply the milestone to your PR.

@mtanino
Copy link
Author

mtanino commented Mar 8, 2017

@roberthbailey

Thanks. I understand the status.
I think this PR isn't such kind of urgent one, I'll wait until the mergebot handles this PR automatically.

@mtanino
Copy link
Author

mtanino commented Mar 16, 2017

@calebamiles
Hi, quick question.
Can we merge this PR into v1.6 because this PR is very simple bug fix?
or should we wait until v1.6 will be released?

@mtanino
Copy link
Author

mtanino commented Mar 17, 2017

cc @jayunit100

@mtanino
Copy link
Author

mtanino commented Apr 3, 2017

@roberthbailey

Hi, The v1.6 was released. Can we proceed to merge of this PR?

@roberthbailey
Copy link
Contributor

Once the tests are green it should get picked up by the submit queue automatically.

@fejta -- why do all of the tests say that they are waiting for status? Shouldn't we automatically re-run tests after 96 hours?

@roberthbailey
Copy link
Contributor

I'm going to close and re-open to see if that tricks the bot.

@roberthbailey roberthbailey reopened this Apr 3, 2017
@mtanino
Copy link
Author

mtanino commented Apr 4, 2017

@roberthbailey

Thank you for your comment. Waiting test status update.

@mikedanese mikedanese added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 4, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 95289ff into kubernetes:master Apr 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@roberthbailey roberthbailey

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Local cluster creation using get-kube-local.sh is never finished
6 participants
@mtanino @k8s-ci-robot @k8s-reviewable @roberthbailey @k8s-github-robot @mikedanese