Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bind mount /etc/resolv.conf from host to containerized mounter #42376

Merged
merged 1 commit into from
Jun 30, 2017
Merged

Add bind mount /etc/resolv.conf from host to containerized mounter #42376

merged 1 commit into from
Jun 30, 2017

Conversation

jingxu97
Copy link
Contributor

@jingxu97 jingxu97 commented Mar 2, 2017 •
edited
Loading

Currently, in containerized mounter rootfs, there is no DNS setup. If client
try to set up volume with host name instead of IP address, it will fail to resolve
the host name.
By bind mount the host's /etc/resolv.conf to mounter rootfs, VM hosts name
could be resolved when using host name during mount.
This PR fixes issue #48212

Fixes issue where you could not mount NFS or glusterFS volumes using hostnames on GCI/GKE with COS images.

@jingxu97
Add bind mount /etc/resolv.conf from host to containerized mounter
4d6a6ec 
Currently, in containerized mounter rootfs, there is no DNS setup. By
bind mount the host's /etc/resolv.conf to mounter rootfs, vm hosts name
could be resolved when using host name during mount.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 2, 2017
@jingxu97 jingxu97 requested a review from vishh March 2, 2017 01:17
@jingxu97 jingxu97 added this to the v1.6 milestone Mar 2, 2017
@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Mar 2, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@gmarek gmarek assigned vishh and unassigned gmarek Mar 2, 2017
@jingxu97
Copy link
Contributor Author

jingxu97 commented Mar 9, 2017

@k8s-bot test this

@vishh
Copy link
Contributor

vishh commented Mar 9, 2017

Is this a bug? If yes, can you update the description to indicate why its a bug and the potential impact from a user perspective?

@jingxu97
Copy link
Contributor Author

jingxu97 commented Mar 9, 2017

@k8s-bot gce etcd3 e2e test this

@jingxu97
Copy link
Contributor Author

@k8s-bot test this

@jingxu97
Copy link
Contributor Author

@k8s-bot gci gke e2e test this

@jingxu97
Copy link
Contributor Author

@k8s-bot cvm gke e2e test this

@jingxu97 jingxu97 mentioned this pull request Mar 13, 2017
Closed
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 13, 2017 •
edited
Loading

@jingxu97: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
Jenkins GKE smoke e2e 4d6a6ec link @k8s-bot cvm gke e2e test this

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@enisoc enisoc modified the milestones: v1.6.1, v1.6 Mar 23, 2017
@enisoc
Copy link
Member

enisoc commented Mar 23, 2017

I'm cleaning out the milestone since we're coming up on the cut. This doesn't seem to be a release-blocker.

@thockin thockin removed this from the v1.6.1 milestone May 27, 2017
@k8s-github-robot
Copy link

This PR hasn't been active in 90 days. Closing this PR. Please reopen if you would like to work towards merging this change, if/when the PR is ready for the next round of review.

cc @jingxu97 @vishh

You can add 'keep-open' label to prevent this from happening again, or add a comment to keep it open another 90 days

@jingxu97 jingxu97 mentioned this pull request Jun 30, 2017
Closed
@jingxu97 jingxu97 reopened this Jun 30, 2017
@msau42 msau42 mentioned this pull request Jun 30, 2017
Closed
@jingxu97
Copy link
Contributor Author

@k8s-bot test this

@msau42
Copy link
Member

msau42 commented Jun 30, 2017

/assign @saad-ali

@saad-ali saad-ali added this to the v1.7 milestone Jun 30, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jingxu97, saad-ali
We suggest the following additional approver: vishh

Assign the PR to them by writing /assign @vishh in a comment when ready.

No associated issue. Update pull-request body to add a reference to an issue, or get approval with /approve no-issue

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Jun 30, 2017
@bowei
Copy link
Member

bowei commented Jun 30, 2017

/retest

@saad-ali saad-ali added release-note Denotes a PR that will be considered when it comes time to generate release notes. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. release-note-label-needed labels Jun 30, 2017
@saad-ali
Copy link
Member

Added a release note

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 43558, 48261, 42376, 46803, 47058)

@k8s-github-robot k8s-github-robot merged commit 87c6fb5 into kubernetes:master Jun 30, 2017
@jingxu97
Copy link
Contributor Author

jingxu97 commented Jul 4, 2017

This PR helps solve the issue in #48212

@wojtek-t wojtek-t mentioned this pull request Jul 10, 2017
Merged
@wojtek-t
Copy link
Member

Cherrypick approved. Automated cherrypick PR is in #48689

@wojtek-t wojtek-t added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jul 10, 2017
@saad-ali saad-ali removed the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jul 10, 2017
@saad-ali saad-ali modified the milestones: v1.6, v1.7 Jul 10, 2017
@saad-ali
Copy link
Member

This has been cherry-picked to 1.7, let's cherry pick to 1.6

k8s-github-robot pushed a commit that referenced this pull request Jul 12, 2017
Merge pull request #48689 from wojtek-t/automated-cherry-pick-of-#423…
2cbce1d 
…76-upstream-release-1.7

Automatic merge from submit-queue

Automated cherry pick of #42376

Cherry pick of #42376 on release-1.7.

#42376 : add bind mount /etc/resolv.conf from host to containerized mounter
@jingxu97 jingxu97 added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jul 14, 2017
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.6" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

@jingxu97 jingxu97 mentioned this pull request Aug 3, 2017
Merged
k8s-github-robot pushed a commit that referenced this pull request Aug 4, 2017
Merge pull request #50114 from jingxu97/automated-cherry-pick-of-#423…
660b295 
…76-upstream-release-1.6

Automatic merge from submit-queue

Automated cherry pick of #42376

Cherry pick of #42376 on release-1.6.

#42376: Add bind mount /etc/resolv.conf from host to containerized
@monotek monotek mentioned this pull request Nov 25, 2017
Closed
@monotek
Copy link
Member

monotek commented Nov 25, 2017

Should this work in 1.8.3?
Had no luck with Google Kuberntes Engine and Minikube :-(

@jingxu97
Copy link
Contributor Author

@monotek I added comment in the issue #2218, please use the full DNS name for the nfs service

@k8s-ci-robot
Copy link
Contributor

@Maannniii: You can't reopen an issue/PR unless you authored it or you are a collaborator.

In response to this:

/remove-lifecycle rotten
/reopen

The issue is not resolved properly. Kindly take this as a priority.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vishh vishh Awaiting requested review from vishh

Assignees

@vishh vishh

@saad-ali saad-ali

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.6
Development

Successfully merging this pull request may close these issues.