Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support context completion for kubectl config use-context #42336

Merged
merged 1 commit into from
Apr 7, 2017
Merged

Support context completion for kubectl config use-context #42336

merged 1 commit into from
Apr 7, 2017

Conversation

superbrothers
Copy link
Member

What this PR does / why we need it:

With this PRt, kubectl is supported context completion for config use-context.

$ ./kubectl config use-context
cluster01  minikube

/ref #42103

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

#29386

Special notes for your reviewer:

Release note:

@superbrothers
Support context completion for kubectl config use-context
a46b04d 
With this commit, kubectl is supported context completion for config
use-context.

```
$ ./kubectl config use-context
cluster01  minikube
```

/refs kubernetes#42103, kubernetes#29386
@k8s-ci-robot
Copy link
Contributor

Hi @superbrothers. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 1, 2017
@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Mar 1, 2017
@pwittrock
Copy link
Member

This won't make 1.6 since it will land after feature freeze. Will review in 1.7

@k8s-reviewable
Copy link

This change is Reviewable

@grodrigues3 grodrigues3 added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 5, 2017
@pwittrock
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 5, 2017
@pwittrock
Copy link
Member

/approve

@pwittrock
Copy link
Member

Thanks for you patience

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pwittrock, superbrothers

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels Apr 5, 2017
@superbrothers
Copy link
Member Author

Thank you for reviewing!

@apelisse apelisse added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. release-note-label-needed labels Apr 7, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 44119, 42538, 43802, 42336, 43396)

@k8s-github-robot k8s-github-robot merged commit 0a7fa69 into kubernetes:master Apr 7, 2017
@superbrothers superbrothers deleted the context-completion-for-config-use-context branch April 7, 2017 22:15
@superbrothers superbrothers mentioned this pull request Jun 29, 2017
Merged
calebamiles added a commit to kubernetes/enhancements that referenced this pull request Jun 29, 2017
@calebamiles
Merge pull request #322 from superbrothers/move-to-enhancement
d612d8f 
Move kubernetes/kubernetes#42336 to Enhancement of CLI
seans3 pushed a commit to seans3/kubernetes that referenced this pull request Apr 10, 2019
@superbrothers
Move kubernetes#42336 to Enhancement of CLI
9981bca
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pwittrock pwittrock

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@superbrothers @k8s-ci-robot @pwittrock @k8s-reviewable @k8s-github-robot @apelisse @grodrigues3