Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS: Deprecate the bash deployment #38772

Merged
merged 1 commit into from
Jan 31, 2017
Merged

AWS: Deprecate the bash deployment #38772

merged 1 commit into from
Jan 31, 2017

Conversation

zmerlynn
Copy link
Member

@zmerlynn zmerlynn commented Dec 14, 2016 •
edited
Loading

What this PR does / why we need it: Add a strong deprecation warning to the kube-up.sh AWS deployment.

Release note:

The bash AWS deployment via kube-up.sh has been deprecated. See http://kubernetes.io/docs/getting-started-guides/aws/ for alternatives.

@zmerlynn zmerlynn added this to the v1.6 milestone Dec 14, 2016
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 14, 2016
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-github-robot k8s-github-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Dec 14, 2016
@k8s-github-robot k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 15, 2016
@krisnova
Copy link
Contributor

This LGTM - especially if we are torching deprecated code!

@k8s-ci-robot
Copy link
Contributor

@kris-nova: you can't LGTM a PR unless you are assigned as a reviewer.

In response to this comment:

/lgtm

If you have questions or suggestions related to this bot's behavior, please file an issue against the kubernetes/test-infra repository.

chrislovecnm
chrislovecnm approved these changes Dec 19, 2016
View reviewed changes
Copy link
Contributor

@chrislovecnm chrislovecnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes me happy

@chrislovecnm
Copy link
Contributor

LGTM

@zmerlynn zmerlynn added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 19, 2016
@zmerlynn
Copy link
Member Author

Self-applying after two LGTM comments.

@k8s-ci-robot
Copy link
Contributor

Jenkins GKE smoke e2e failed for commit 783045ce9d95a0cea19ec5885b5dd4e4683581ff. Full PR test history.

The magic incantation to run this job again is @k8s-bot cvm gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@zmerlynn
Copy link
Member Author

@k8s-bot cvm gke e2e test this

@k8s-ci-robot
Copy link
Contributor

Jenkins GCI GKE smoke e2e failed for commit 783045ce9d95a0cea19ec5885b5dd4e4683581ff. Full PR test history.

The magic incantation to run this job again is @k8s-bot gci gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@zmerlynn
Copy link
Member Author

@k8s-bot gci gke e2e test this

@chrislovecnm
Copy link
Contributor

@zmerlynn to @justinsb's point we probably need to bring this up on our sig and sig-cluster-lifecycle. I really want this merged, but I also don't want to shoot ourselves in the foot either.

chrislovecnm
chrislovecnm suggested changes Dec 19, 2016
View reviewed changes
Copy link
Contributor

@chrislovecnm chrislovecnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to do a bit more due diligence on this. It is deprecated, but not scheduled for removal. I really want to do it, but I want to do it with a little more information.

@zmerlynn zmerlynn added do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Dec 19, 2016
@zmerlynn zmerlynn removed the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Jan 3, 2017
@arun-gupta arun-gupta mentioned this pull request Jan 13, 2017
Closed
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] Needs approval from an approver in each of these OWNERS Files:

We suggest the following people:
cc @jbeda
You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@zmerlynn
Copy link
Member Author

@chrislovecnm @justinsb: Ping. I'd like to get this warning in, at least. We can gut it in a separate PR.

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 30, 2017
@zmerlynn zmerlynn assigned justinsb and unassigned zmerlynn Jan 30, 2017
@justinsb
Copy link
Member

I actually think we should still try to remove it in 1.6, but this LGTM.

justinsb
justinsb approved these changes Jan 31, 2017
View reviewed changes
Copy link
Member

@justinsb justinsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roberthbailey
Copy link
Contributor

/lgtm /approve

@chrislovecnm
Copy link
Contributor

This makes me happy.

@zmerlynn zmerlynn added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 31, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 38772, 38797, 40732, 40740)

@k8s-github-robot k8s-github-robot merged commit 60c66dd into kubernetes:master Jan 31, 2017
@zmerlynn zmerlynn mentioned this pull request Feb 27, 2017
Merged
zmerlynn added a commit to zmerlynn/kubernetes that referenced this pull request Feb 27, 2017
@zmerlynn
AWS: Kill bash deployment
f07aee2 
c.f. kubernetes#38772, kubernetes#42194 and https://k8s-testgrid.appspot.com/google-aws#aws

cluster/kube-up.sh with KUBERNETES_PROVIDER=aws has been broken on 1.6
for a couple of months now. No one is supporting it. Nuke.
@zmerlynn zmerlynn mentioned this pull request Feb 27, 2017
Merged
@zmerlynn zmerlynn modified the milestones: v1.5, v1.6 Feb 27, 2017
@zmerlynn
Copy link
Member Author

zmerlynn commented Feb 27, 2017 •
edited
Loading

c.f. #42196 and #42194 - after a brief discussion, we're nuking the bash deployment completely. No one has stepped up to fix master, and I'm not sure any of us have time right now.

cc @mwielgus for v1.5 approval.

@zmerlynn zmerlynn deleted the kube-up-aws-dead branch February 27, 2017 22:56
k8s-github-robot pushed a commit that referenced this pull request Feb 28, 2017
Merge pull request #42196 from zmerlynn/nuke-kube-up-aws
36a5c00 
Automatic merge from submit-queue

AWS: Kill bash deployment

c.f. #38772, #42194 and https://k8s-testgrid.appspot.com/google-aws#aws

cluster/kube-up.sh with KUBERNETES_PROVIDER=aws has been broken on 1.6
for a couple of months now. No one is supporting it. Nuke.

```release-note
Deployment of AWS Kubernetes clusters using the in-tree bash deployment (i.e. cluster/kube-up.sh or get-kube.sh) is obsolete. v1.5.x will be the last release to support cluster/kube-up.sh with AWS. For a list of viable alternatives, see: http://kubernetes.io/docs/getting-started-guides/aws/ 
```
k8s-github-robot pushed a commit that referenced this pull request Jul 5, 2017
Merge pull request #42194 from zmerlynn/automated-cherry-pick-of-#387…
753dfe6 
…72-upstream-release-1.5

Automatic merge from submit-queue

Automated cherry pick of #38772

Cherry pick of #38772 on release-1.5, changing deprecation to 1.6.

#38772: AWS: Add a strong deprecation message
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.5" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrislovecnm chrislovecnm chrislovecnm requested changes

@krisnova krisnova krisnova approved these changes

@justinsb justinsb justinsb approved these changes

Assignees

@justinsb justinsb

@zmerlynn zmerlynn

@roberthbailey roberthbailey

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.
9 participants
@zmerlynn @k8s-reviewable @krisnova @k8s-ci-robot @chrislovecnm @k8s-github-robot @justinsb @roberthbailey @k8s-cherrypick-bot