Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Openstack provider #21737

Merged
merged 34 commits into from
May 11, 2016
Merged

Openstack provider #21737

merged 34 commits into from
May 11, 2016

Conversation

zreigz
Copy link
Contributor

@zreigz zreigz commented Feb 23, 2016

Our pull request delivers solution to create Kubernetes cluster on the top of OpenStack. Heat OpenStack Orchestration engine describes the infrastructure for Kubernetes cluster. CentoOS images are used for Kubernetes host machines.

We tested our solution with DevStack and Citycloud provider.

We believe that our solution will fill the gap that which is on the market.


This change is Reviewable

@k8s-bot
Copy link

k8s-bot commented Feb 23, 2016

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

1 similar comment
@k8s-bot
Copy link

k8s-bot commented Feb 23, 2016

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

@k8s-github-robot k8s-github-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 23, 2016
@k8s-bot
Copy link

k8s-bot commented Feb 23, 2016

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

@zreigz
Copy link
Contributor Author

zreigz commented Feb 24, 2016

@ohtake is also a author of those commits

@k8s-bot
Copy link

k8s-bot commented Feb 28, 2016

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

@davidopp
Copy link
Member

davidopp commented Mar 2, 2016

ok to test

@davidopp
Copy link
Member

davidopp commented Mar 2, 2016

@ohtake needs to sign the CLA.

@davidopp
Copy link
Member

davidopp commented Mar 2, 2016

cc/ @ashw7n

@ohtake
Copy link
Contributor

ohtake commented Mar 3, 2016

@davidopp I have just singned the CLA. Could you re-verify the CLA?

@k8s-github-robot
Copy link

Adding label:do-not-merge because PR changes docs prohibited to auto merge
See http://kubernetes.github.io/docs/editdocs/ for information about editting docs

@k8s-github-robot k8s-github-robot added do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 4, 2016
@bgrant0607
Copy link
Member

I don't think the CLA bot ever works for PRs with multiple authors.

@bgrant0607
Copy link
Member

We're still trying to get 1.2 out the door and have a couple other new cloudproviders to review, so this will need to wait for a little while.

It would also be useful to have some people using K8s on Openstack to review. I suggest posting to kubernetes-dev to plead for reviewers.

@zreigz
Copy link
Contributor Author

zreigz commented Mar 9, 2016

I've created post on kubernetes-der regarding to openstack-provider:
https://groups.google.com/forum/#!topic/kubernetes-dev/t1-0zG3Lmeg

I hope someone will be interested.

@eparis eparis removed the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Mar 9, 2016
@zreigz
Copy link
Contributor Author

zreigz commented May 9, 2016

This PR and documentation kubernetes/website#74 ready for review
PTAL

@elsonrodriguez
Copy link
Contributor

@quinton-hoole Looks like the bot didn't like you :)

@ghost
Copy link

ghost commented May 9, 2016

@elsonrodriguez That only because commits were added after I gave the LGTM. So bot is being good :-) New commits also LGTM. Re-adding label.

@ghost ghost added lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-merge and removed cla: no labels May 9, 2016
@ghost ghost assigned ghost and unassigned davidopp May 9, 2016
@ghost
Copy link

ghost commented May 9, 2016

@elsonrodriguez Oh, I see what you mean, the bot reassigned it. That was due to a bug in github a week or so ago. I've manually re-assigned back to myself.

@idvoretskyi
Copy link
Member

idvoretskyi commented May 9, 2016

@zreigz @elsonrodriguez it is not mandatory, but nice to have:

  1. requirements.txt file with the desired python-'project'client versions (to install it easily with pip install -r requirements.txt command/update the docs with this as well;
  2. Replace "OpenStack" with "OpenStack-Heat" on https://github.com/FujitsuEnablingSoftwareTechnologyGmbH/kubernetes/blob/openstack-provider/cluster/get-kube.sh#L41 as we are expecting other different OpenStack-related providers.
  3. Replace "minion" with "node", i.e. - https://github.com/FujitsuEnablingSoftwareTechnologyGmbH/kubernetes.github.io/blob/openstack-provider-doc/docs/getting-started-guides/openstack-heat.md#sshing-to-your-nodes

Everything else LGTM. @quinton-hoole, please, take a look, possibly you have some other/extra suggestions.

@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 10, 2016
@zreigz
Copy link
Contributor Author

zreigz commented May 10, 2016

Thanks for suggestions. Regarding to:

  1. It sounds as a good enhancement for the future. For sure we will do it.
  2. Done
  3. minion is used as user for instances. It is not only matter of documentation.
    https://github.com/FujitsuEnablingSoftwareTechnologyGmbH/kubernetes/blob/openstack-provider/cluster/openstack-heat/kubernetes-heat/fragments/kube-user.yaml#L4

@k8s-bot
Copy link

k8s-bot commented May 10, 2016

GCE e2e build/test passed for commit 892c2ab.

@elsonrodriguez
Copy link
Contributor

@quinton-hoole Another commit snuck in, could you take another look?

@idvoretskyi
Copy link
Member

@zreigz
3) please, change that. Don't let people be confused.

@ghost ghost added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 10, 2016
@elsonrodriguez
Copy link
Contributor

@zreigz @idvoretskyi That is a minor cosmetic issue. Almost every other kube-up provider still makes a reference to minions in their usage/code, along with the salt manifests.

I do think the names could be normalized, but that is squarely in the territory of a future PR.

@idvoretskyi
Copy link
Member

@elsonrodriguez @zreigz agree.
LGTM

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented May 11, 2016

GCE e2e build/test passed for commit 892c2ab.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 17c3f19 into kubernetes:master May 11, 2016
@zreigz zreigz deleted the openstack-provider branch May 11, 2016 07:07
@pwittrock
Copy link
Member

@zreigz
@quinton-hoole

Would you provide an update on the status + ETA for the documentation for this feature as well as add any PRs as they are created?

Not Started / In Progress / In Review / Done

Expected Merge Time:

Thanks
@pwittrock

@elsonrodriguez
Copy link
Contributor

@pwittrock
@zreigz
@quinton-hoole

Documentation is here: http://kubernetes.io/docs/getting-started-guides/openstack-heat/

And I have a pending PR to fix issues here: kubernetes/website#534

Any review/testing would be appreciated.

@pwittrock
Copy link
Member

@elsonrodriguez Is this already available or will it be available in v1.3? The docs you linked are live, so it may be confusing to users if the feature is not available in the current release.

@elsonrodriguez
Copy link
Contributor

@pwittrock 1.3 only, I can put a warning regarding the curl | bash pattern, and say that only 1.3 releases will work for the tar pattern.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.