-
Notifications
You must be signed in to change notification settings - Fork 39.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Openstack provider #21737
Openstack provider #21737
Conversation
Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist") If this message is too spammy, please complain to ixdy. |
1 similar comment
Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist") If this message is too spammy, please complain to ixdy. |
Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist") If this message is too spammy, please complain to ixdy. |
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
@ohtake is also a author of those commits |
Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist") If this message is too spammy, please complain to ixdy. |
ok to test |
@ohtake needs to sign the CLA. |
cc/ @ashw7n |
@davidopp I have just singned the CLA. Could you re-verify the CLA? |
Adding label:do-not-merge because PR changes docs prohibited to auto merge |
I don't think the CLA bot ever works for PRs with multiple authors. |
We're still trying to get 1.2 out the door and have a couple other new cloudproviders to review, so this will need to wait for a little while. It would also be useful to have some people using K8s on Openstack to review. I suggest posting to kubernetes-dev to plead for reviewers. |
I've created post on kubernetes-der regarding to openstack-provider: I hope someone will be interested. |
This PR and documentation kubernetes/website#74 ready for review |
@quinton-hoole Looks like the bot didn't like you :) |
@elsonrodriguez That only because commits were added after I gave the LGTM. So bot is being good :-) New commits also LGTM. Re-adding label. |
@elsonrodriguez Oh, I see what you mean, the bot reassigned it. That was due to a bug in github a week or so ago. I've manually re-assigned back to myself. |
@zreigz @elsonrodriguez it is not mandatory, but nice to have:
Everything else LGTM. @quinton-hoole, please, take a look, possibly you have some other/extra suggestions. |
Thanks for suggestions. Regarding to:
|
GCE e2e build/test passed for commit 892c2ab. |
@quinton-hoole Another commit snuck in, could you take another look? |
@zreigz |
@zreigz @idvoretskyi That is a minor cosmetic issue. Almost every other kube-up provider still makes a reference to minions in their usage/code, along with the salt manifests. I do think the names could be normalized, but that is squarely in the territory of a future PR. |
@elsonrodriguez @zreigz agree. |
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
GCE e2e build/test passed for commit 892c2ab. |
Automatic merge from submit-queue |
Would you provide an update on the status + ETA for the documentation for this feature as well as add any PRs as they are created? Not Started / In Progress / In Review / Done Expected Merge Time: Thanks |
@pwittrock Documentation is here: http://kubernetes.io/docs/getting-started-guides/openstack-heat/ And I have a pending PR to fix issues here: kubernetes/website#534 Any review/testing would be appreciated. |
@elsonrodriguez Is this already available or will it be available in v1.3? The docs you linked are live, so it may be confusing to users if the feature is not available in the current release. |
@pwittrock 1.3 only, I can put a warning regarding the |
Our pull request delivers solution to create Kubernetes cluster on the top of OpenStack. Heat OpenStack Orchestration engine describes the infrastructure for Kubernetes cluster. CentoOS images are used for Kubernetes host machines.
We tested our solution with DevStack and Citycloud provider.
We believe that our solution will fill the gap that which is on the market.
This change is