Skip to content

integration/apiserver: ignore discovery+availability reqs in front-proxy test #129031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sttts wants to merge 1 commit into from
Closed

integration/apiserver: ignore discovery+availability reqs in front-proxy test #129031

sttts wants to merge 1 commit into from

Conversation

@sttts
Copy link
Contributor

@sttts sttts commented Nov 29, 2024 •
edited
Loading

What type of PR is this?

/kind flake

What this PR does / why we need it:

kube-apiserver sends requests to aggregated apiservers for (aggregated) discovery and for availability checking. These are sent with a system:kube-aggregator user name (instead of system:aggregator that is used for openapi; no special reason, it's just implemented like that). This PR adds system:kube-aggregator as another user that is ignored when waiting for service account coming through in the front proxy integration tests.

Which issue(s) this PR fixes:

Fixes #128565.

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/flake Categorizes issue or PR as related to a flaky test. labels Nov 29, 2024
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 29, 2024

Please note that we're already in Test Freeze for the release-1.32 branch. This means every merged PR will be automatically fast-forwarded via the periodic ci-fast-forward job to the release branch of the upcoming v1.32.0 release.

Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Fri Nov 29 10:40:14 UTC 2024.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 29, 2024
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 29, 2024

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 29, 2024
@sttts sttts changed the title integration/apiserver: ignore discovery+available reqs in front-proxy… integration/apiserver: ignore discovery+available reqs in front-proxy test Nov 29, 2024
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 29, 2024
@sttts sttts changed the title integration/apiserver: ignore discovery+available reqs in front-proxy test integration/apiserver: ignore discovery+availability reqs in front-proxy test Nov 29, 2024
@sttts sttts force-pushed the sttts-test-flake-128565 branch from 3c2457a to bbeb81e Compare November 29, 2024 12:35
@aojea
Copy link
Member

aojea commented Nov 29, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 29, 2024
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 29, 2024

LGTM label has been added.

DetailsGit tree hash: 3b1cb79aadb15ac81c61705d34cb049204cb83ab

@sttts
Copy link
Contributor Author

sttts commented Nov 29, 2024

That linter takes long.

@aojea
Copy link
Member

aojea commented Nov 30, 2024

That linter takes long.

the job has been removed recently kubernetes/test-infra#33857

@sttts sttts force-pushed the sttts-test-flake-128565 branch from bbeb81e to 1f98234 Compare December 2, 2024 08:18
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 2, 2024
@k8s-ci-robot k8s-ci-robot requested a review from aojea December 2, 2024 08:18
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 2, 2024

New changes are detected. LGTM label has been removed.

@sttts
Copy link
Contributor Author

sttts commented Dec 2, 2024

/retest

@pohly
Copy link
Contributor

pohly commented Dec 2, 2024

As discussed on Slack: someone with the necessary permissions needs to this because
pull-kubernetes-verify-lint was removed and will not come back to post a successful test result:

/override pull-kubernetes-verify-lint

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 2, 2024

@pohly: pohly unauthorized: /override is restricted to Repo administrators.

Details

In response to this:

As discussed on Slack: someone with the necessary permissions needs to this because
pull-kubernetes-verify-lint was removed and will not come back to post a successful test result:

/override pull-kubernetes-verify-lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sttts
Copy link
Contributor Author

sttts commented Dec 2, 2024

/override pull-kubernetes-verify-lint

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 2, 2024

@sttts: sttts unauthorized: /override is restricted to Repo administrators.

Details

In response to this:

/override pull-kubernetes-verify-lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sttts sttts closed this Dec 2, 2024
@sttts sttts reopened this Dec 2, 2024
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 2, 2024

Please note that we're already in Test Freeze for the release-1.32 branch. This means every merged PR will be automatically fast-forwarded via the periodic ci-fast-forward job to the release branch of the upcoming v1.32.0 release.

Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Mon Dec 2 10:42:22 UTC 2024.

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 5, 2024

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 5, 2024
@sttts
Copy link
Contributor Author

sttts commented Dec 16, 2024

/close

Same change was done in #129081.

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 16, 2024

@sttts: Closed this PR.

Details

In response to this:

/close

Same change was done in #129081.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

@aojea aojea Awaiting requested review from aojea

Assignees

@aojea aojea

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/flake Categorizes issue or PR as related to a flaky test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Failure cluster [44fa5cdb...]: TestFrontProxyConfig/WithoutUID:

4 participants

@sttts @k8s-ci-robot @aojea @pohly