Skip to content

Add Feature:ExecProbeTimeout tag to exec readiness/liveness probe tests #106743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
azylinski wants to merge 1 commit into from
Closed

Add Feature:ExecProbeTimeout tag to exec readiness/liveness probe tests #106743

azylinski wants to merge 1 commit into from

Conversation

@azylinski
Copy link
Contributor

@azylinski azylinski commented Nov 30, 2021 •
edited
Loading

Adding missing Feature tag would make it easier to skip in testgrid's correctness tests

NONE

/kind cleanup
/kind failing-test

/sig node

/cc @jkaniuk

@k8s-ci-robot k8s-ci-robot requested a review from jkaniuk November 30, 2021 14:16
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 30, 2021
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 30, 2021

@azylinski: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Nov 30, 2021
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 30, 2021

Welcome @azylinski!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 30, 2021

Hi @azylinski. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 30, 2021
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 30, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: azylinski
To complete the pull request process, please assign random-liu after the PR has been reviewed.
You can assign the PR to them by writing /assign @random-liu in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/test sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 30, 2021
@jkaniuk
Copy link
Contributor

jkaniuk commented Nov 30, 2021

/lgtm

@jkaniuk
Copy link
Contributor

jkaniuk commented Nov 30, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 30, 2021
@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 30, 2021
SergeyKanzhelev
SergeyKanzhelev reviewed Nov 30, 2021
View reviewed changes
test/e2e/common/node/container_probe.go
Description: A Pod is created with liveness probe with a Exec action on the Pod. If the liveness probe call does not return within the timeout specified, liveness probe MUST restart the Pod.
*/
ginkgo.It("should be restarted with an exec liveness probe with timeout [MinimumKubeletVersion:1.20] [NodeConformance]", func() {
ginkgo.It("should be restarted with an exec liveness probe with timeout [MinimumKubeletVersion:1.20] [NodeConformance] [Feature:ExecProbeTimeout]", func() {
Copy link
Member

@SergeyKanzhelev SergeyKanzhelev Nov 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't want to lose coverage of this functionality in OSS Nodeconformance test grid. Adding Feature will exclude this test. I sent a proposal to address it: kubernetes/enhancements#3042

Also, this is a known issue that e2eskipper.SkipUnlessFeatureGateEnabled is not working as expected all the time.

I don't think we can take this PR as is. Perhaps looking into why skipper is not working as expected would be a better course of actions.

/hold

Copy link
Contributor Author

@azylinski azylinski Jan 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to: https://kubernetes.io/docs/reference/command-line-tools-reference/feature-gates/

The ExecProbeTimeout feature is enabled in GA since 1.20.

Also, in the same doc:
"
A General Availability (GA) feature is also referred to as a stable feature. It means:

  • The feature is always enabled; you cannot disable it.
    "

In other words, the e2eskipper.SkipUnlessFeatureGateEnabled skip would never apply - and the test would always run.

Copy link
Contributor Author

@azylinski azylinski Jan 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Saying that - adding [Feature:ExecProbeTimeout] tag is not correct anymore, since the feature is in GA already.

Sergey, do you have any suggestions, how to follow-up with this issues?

Copy link
Contributor

@jkaniuk jkaniuk Jan 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the feature is always enabled, you can close this PR

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 30, 2021
@azylinski azylinski closed this Jan 4, 2022
@azylinski azylinski deleted the test-feature-ExecProbeTimeout-prefix branch January 4, 2022 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jkaniuk jkaniuk Awaiting requested review from jkaniuk

1 more reviewer

@SergeyKanzhelev SergeyKanzhelev SergeyKanzhelev left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@jkaniuk jkaniuk

Labels

area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

SIG Node CI/Test Board
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@azylinski @k8s-ci-robot @jkaniuk @SergeyKanzhelev