Skip to content

[WIP] CNI update for k8s 1.9 #4097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
chrislovecnm wants to merge 4 commits into from
Closed

[WIP] CNI update for k8s 1.9 #4097

chrislovecnm wants to merge 4 commits into from

Conversation

@chrislovecnm
Copy link
Contributor

@chrislovecnm chrislovecnm commented Dec 17, 2017 •
edited
Loading

This PR refactors cni to use remote SHA1 files, and add CNI 0.6.0 for k8s 1.9.

This PR is dependent on the proper staging of the previous CNI tarballs and SHA1 files see kubernetes/kubernetes#51250 since they are not updated properly yet.

Most of these commits should drop out after a couple of merges.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 17, 2017
@chrislovecnm chrislovecnm changed the title [WIP} CNI update for k8s 1.9 [WIP] CNI update for k8s 1.9 Dec 17, 2017
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 17, 2017

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
We suggest the following additional approver: andrewsykim

Assign the PR to them by writing /assign @andrewsykim in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 18, 2017
@k8s-github-robot
Copy link

k8s-github-robot commented Dec 19, 2017

@chrislovecnm PR needs rebase

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 19, 2017
@k8s-github-robot k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 20, 2017
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 20, 2017

@chrislovecnm: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kops-e2e-kubernetes-aws 198963c link /test pull-kops-e2e-kubernetes-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@chrislovecnm chrislovecnm mentioned this pull request Dec 30, 2017
Merged
@k8s-github-robot
Copy link

k8s-github-robot commented Jan 3, 2018

@chrislovecnm PR needs rebase

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 3, 2018
@StevenACoffman
Copy link
Contributor

StevenACoffman commented Jan 26, 2018

The upstream issue blocking this is kubernetes/kubernetes#57341 btw.

@chrislovecnm
Copy link
Contributor Author

chrislovecnm commented Jan 26, 2018

An update. CNI updates are in master for K8s 1.9. This PR refactors the code base to use one pattern to download files with md5 checksums available via an HTTP file.

@justinsb justinsb added this to the 1.9 milestone Feb 21, 2018
@justinsb
Copy link
Member

justinsb commented Feb 21, 2018

Looks like you did this in #4175 - can we close @chrislovecnm ?

@blakebarnett
Copy link

blakebarnett commented Feb 21, 2018

Does this require that we update any of the networking addons for their CNI version support?

@chrislovecnm
Copy link
Contributor Author

chrislovecnm commented Feb 26, 2018

Closing because I do not think this is going to get fixed upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

blocks-next cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

1.9.0

Development

Successfully merging this pull request may close these issues.

6 participants

@chrislovecnm @k8s-ci-robot @k8s-github-robot @StevenACoffman @justinsb @blakebarnett