Skip to content

Migrate the webhook-certgen program to inside ingress repo #7475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 1 commit into from
Aug 10, 2021
Merged

Migrate the webhook-certgen program to inside ingress repo #7475

k8s-ci-robot merged 1 commit into from
Aug 10, 2021

Conversation

@rikatz
Copy link
Member

@rikatz rikatz commented Aug 10, 2021

What this PR does / why we need it:

This PR migrates the webhook-certgen program from https://github.com/jet/kube-webhook-certgen to here, adapting the code base to work with k8s 1.22

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 10, 2021
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Aug 10, 2021

@rikatz: This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 10, 2021
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Aug 10, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rikatz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 10, 2021
@rikatz rikatz added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 10, 2021
@rikatz
Copy link
Member Author

rikatz commented Aug 10, 2021

Force merging to see if cloudbuild passes

@k8s-ci-robot k8s-ci-robot merged commit 492c7b0 into kubernetes:main Aug 10, 2021
@rikatz rikatz deleted the webhook-certgen branch November 15, 2021 19:55
@chaunceyjiang chaunceyjiang mentioned this pull request Jan 10, 2022
Merged
@michaelbeaumont michaelbeaumont mentioned this pull request Jan 13, 2022
Closed
rchshld pushed a commit to joomcode/ingress-nginx that referenced this pull request May 19, 2023
@rikatz @rchshld
Migrate the webhook-certgen program to inside ingress repo (kubernete…
2b80022 
…s#7475)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bowei bowei Awaiting requested review from bowei

@ElvinEfendi ElvinEfendi Awaiting requested review from ElvinEfendi

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rikatz @k8s-ci-robot