[Bucket API] KEP updates for API review #2813
Conversation
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
sig/storage
wlan0
force-pushed
the
master
branch
2 times, most recently
from
b2ee7c9 to
6ff0006
Compare
|
@wlan0 can you link the KEP in the title of this PR and description? |
| BucketAccessClassName string | ||
| } | ||
|
|
||
| Status BucketRequestStatus { |
There was a problem hiding this comment.
Typo I assume. Should be BucketAccessRequestStatus
| // for creating the bucket | ||
| // +optional | ||
| Parameters map[string]string | ||
| } |
There was a problem hiding this comment.
There is no API linkage between Bucket and BucketAccess. So will COSI be making GET (or cache) calls to fetch all BAs for a given B?
There was a problem hiding this comment.
Also, I haven't yet seen 1:n mapping relations defined between the COSI resources. Is it 1 BR per B? One BAR per BA? Many BAs per B? etc.
There was a problem hiding this comment.
Deletion is the only reasons we need this list. However, this cascading deletion behavior can be achieved using owner references, where deleting a BR deletes the B and all other associated BA's.
Is there any other reason for us to get this information? If not, then we should be fine
There was a problem hiding this comment.
Also, I haven't yet seen 1:n mapping relations defined between the COSI resources. Is it 1 BR per B? One BAR per BA? Many BAs per B? etc.
The resources are loosely coupled, for instance, similar to how pods and nodes are related. Whenever a stronger coupling is needed, we directly reference the related object in the referring object.
…for all, and introduce referencePolicy for future cross-NS bucket sharing
…e for bucketAccess -> bucketClaim -> bucket references
…/non-namespaced resource
k8s-ci-robot
removed
the
lgtm
|
PRR Is good for alpha. For beta promotion, having a solid story for cluster-admins to observe cluster-wide status will be important /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, msau42, wlan0 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/milestone v1.25 |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
No description provided.