Updating FlexVolume doc with capabilities addition. #786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
/assign @saad-ali @chakri-nelluri |
|
@verult: GitHub didn't allow me to assign the following users: chakri-nelluri. Note that only kubernetes members can be assigned. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-github-robot
added
the
size/XS
jingxu97
reviewed
Aug 16, 2017
contributors/devel/flexvolume.md
Outdated
| @@ -19,7 +19,8 @@ Call-outs are invoked from Controller-manager only when "--enable-controller-att | |||
| ### Driver invocation model: | |||
|
|
|||
| #### Init: | |||
| Initializes the driver. Called during Kubelet & Controller manager initialization. | |||
| Initializes the driver. Called during Kubelet & Controller manager initialization. On success, a capabilities map is returned. | |||
| Currently the only capability supported is `attach`, indicating whether the driver requires attach and detach operations. This field is *required*, although for backward-compatibility the default value is set to `true`, i.e. requires attach and detach. | |||
There was a problem hiding this comment.
Can user set it to false? and what does it mean?
verult
force-pushed
the
Capabilities
branch
2 times, most recently
from
2f40230
to
d4135c3
Compare
k8s-github-robot
added
size/S
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
Automatic merge from submit-queue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following PR introduces a FlexVolume API change, so the documentation needs to be updated.
kubernetes/kubernetes#47503