Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go version workflows #919

Merged
merged 3 commits into from
May 17, 2024
Merged

Go version workflows #919

merged 3 commits into from
May 17, 2024

Conversation

hakman
Copy link
Member

@hakman hakman commented May 17, 2024

What type of PR is this?

Uncomment only one, leave it on its own line:

/kind api-change
/kind bug

/kind cleanup

/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:
N/A

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels May 17, 2024
@k8s-ci-robot k8s-ci-robot requested review from dims and nckturner May 17, 2024 11:41
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 17, 2024
@hakman
Copy link
Member Author

hakman commented May 17, 2024

/cc @dims @cartermckinnon

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 17, 2024
@hakman hakman mentioned this pull request May 17, 2024
Closed
@hakman hakman force-pushed the go-version-workflows branch from db6516b to ebb1fb5 Compare May 17, 2024 11:53
@hakman hakman force-pushed the go-version-workflows branch from ebb1fb5 to e747b3f Compare May 17, 2024 11:56
@dims
Copy link
Member

dims commented May 17, 2024

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 17, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 17, 2024
@dims
Copy link
Member

dims commented May 17, 2024

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 17, 2024
@dims dims mentioned this pull request May 17, 2024
Closed
@hakman hakman mentioned this pull request May 17, 2024
Closed
@k8s-ci-robot k8s-ci-robot merged commit 6a08c73 into kubernetes:master May 17, 2024
12 of 13 checks passed
@hakman hakman deleted the go-version-workflows branch May 17, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dims dims Awaiting requested review from dims

@nckturner nckturner Awaiting requested review from nckturner

@cartermckinnon cartermckinnon Awaiting requested review from cartermckinnon

Assignees

@dims dims

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hakman @dims @k8s-ci-robot @cartermckinnon