Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract fargate related code into a standalone file #917

Merged
merged 1 commit into from
May 23, 2024
Merged

Extract fargate related code into a standalone file #917

merged 1 commit into from
May 23, 2024

Conversation

dims
Copy link
Member

@dims dims commented May 17, 2024 •
edited
Loading

Fargate Node is a "variant" of regular EC2 nodes and needs special processing, originally the code for handling this variant was sprinkled across the code base. In this PR, we split it out behind the Variant interface and it also gets registered using RegisterVariant when the package is imported explicitly. For now this is good enough to inspect how the code is different for this variation of the regular code as well as make changes if/when needed. We can even figure out how to use tags to build aws-cloud-controller-manager without this variant getting registered for example for CAPA or kops etc. If in the future there is a need for something other variant, we can cleanly drop in another package if needed similar to how we do this for fargate.

NOTE: design is based on how we implemented support for different container runtimes in cadvisor:
https://github.com/google/cadvisor/tree/master/container

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 17, 2024
@k8s-ci-robot k8s-ci-robot added needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 17, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If cloud-provider-aws contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 17, 2024
@dims dims force-pushed the extract-fargate-into-a-stand-alone-file branch 2 times, most recently from 5c3c8a8 to f32ccd2 Compare May 17, 2024 10:49
@hakman
Copy link
Member

hakman commented May 17, 2024

@dims You will probably need to rebase to fix govulncheck.

@dims dims force-pushed the extract-fargate-into-a-stand-alone-file branch 2 times, most recently from 2f0d025 to 2fa21c4 Compare May 17, 2024 12:41
@dims
Copy link
Member Author

dims commented May 17, 2024

@dims You will probably need to rebase to fix govulncheck.

thanks @hakman Done!

@dims dims force-pushed the extract-fargate-into-a-stand-alone-file branch from 2fa21c4 to c4d97a4 Compare May 18, 2024 03:10
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 18, 2024
@dims dims force-pushed the extract-fargate-into-a-stand-alone-file branch 6 times, most recently from 721c565 to 976491a Compare May 19, 2024 02:03
@dims dims changed the title [WIP] extract fargate related code into a standalone file Extract fargate related code into a standalone file May 19, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 19, 2024
@dims
Copy link
Member Author

dims commented May 19, 2024

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 19, 2024
@dims dims force-pushed the extract-fargate-into-a-stand-alone-file branch from 976491a to 2e10be6 Compare May 19, 2024 02:17
@dims
Copy link
Member Author

dims commented May 19, 2024

/kind cleanup

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels May 19, 2024
@dims
Copy link
Member Author

dims commented May 19, 2024

/assign @hakman @kmala @cartermckinnon
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 19, 2024
@k8s-ci-robot
Copy link
Contributor

@dims: GitHub didn't allow me to assign the following users: kmala.

Note that only kubernetes members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @hakman @kmala @cartermckinnon
/hold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@rsumukha
Copy link

Ran a prow test suite against to validate Fargate tests, it was mostly successful with an unrelated test failure. gtg from Fargate side

@kmala
Copy link
Member

kmala commented May 23, 2024

/lgtm

@k8s-ci-robot
Copy link
Contributor

@kmala: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dims
Copy link
Member Author

dims commented May 23, 2024

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 23, 2024
@hakman
Copy link
Member

hakman commented May 23, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 23, 2024
@hakman
Copy link
Member

hakman commented May 23, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 23, 2024
@k8s-ci-robot k8s-ci-robot merged commit e6456fd into kubernetes:master May 23, 2024
13 checks passed
@taewonk-amzn taewonk-amzn mentioned this pull request Jun 3, 2024
Closed
@sanjams2 sanjams2 mentioned this pull request Jun 3, 2024
Open
This was referenced Jun 5, 2024
Merged
Merged
k8s-ci-robot added a commit that referenced this pull request Jun 6, 2024
@k8s-ci-robot
Merge pull request #945 from dims/automated-cherry-pick-of-#917-upstr…
3a75a4c 
…eam-release-1.29

Automated cherry pick of #917: extract fargate into a standalone file
k8s-ci-robot added a commit that referenced this pull request Jun 6, 2024
@k8s-ci-robot
Merge pull request #946 from dims/automated-cherry-pick-of-#917-upstr…
051b37d 
…eam-release-1.30

Automated cherry pick of #917: extract fargate into a standalone file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cartermckinnon cartermckinnon cartermckinnon left review comments

@hakman hakman Awaiting requested review from hakman

@olemarkus olemarkus Awaiting requested review from olemarkus

Assignees

@olemarkus olemarkus

@hakman hakman

@cartermckinnon cartermckinnon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@dims @k8s-ci-robot @hakman @rsumukha @kmala @cartermckinnon @olemarkus