Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies #914

Merged
merged 1 commit into from
May 17, 2024
Merged

Update dependencies #914

merged 1 commit into from
May 17, 2024

Conversation

github-actions[bot]
Copy link

Updating go.mod with latest dependencies.

@github-actions github-actions bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. labels May 13, 2024
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 13, 2024
@k8s-ci-robot k8s-ci-robot added needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 13, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @github-actions[bot]. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If cloud-provider-aws contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 13, 2024
@hakman
Copy link
Member

hakman commented May 16, 2024

/retest

@cartermckinnon
Copy link
Contributor

@hakman the CI is broken:

error fetching s3://cloud-provider-aws-shared-e2e/test-cluster-20240516033144.k8s/config: operation error S3: GetObject, get identity: get credentials: failed to refresh cached credentials, failed to retrieve credentials, operation error STS: AssumeRoleWithWebIdentity, https response error StatusCode: 0, RequestID: , request send failed, Post "https://sts.us-east-1.api.aws/": dial tcp: lookup sts.us-east-1.api.aws on 172.20.0.10:53: no such host

I think the issue is this: https://github.com/kubernetes/kops/blob/937663a62445cc395551f3403e67ab76597d49bd/util/pkg/vfs/s3context.go#L90

DualStackEndpointStateEnabled is causing a non-existant STS endpoint to be used by the credential provider.

@hakman
Copy link
Member

hakman commented May 16, 2024

Thanks @cartermckinnon!
@rifelpet @ameukam any thoughts, not exactly sure why this happens only at the end of the test, during cluster deletion.

@ameukam
Copy link
Member

ameukam commented May 16, 2024

No idea. I suspect the upgrade of the AWS SDK.

@cartermckinnon
Copy link
Contributor

cartermckinnon commented May 16, 2024 •
edited
Loading

Agree, this ultimately looks like an SDK bug, don't see a reasonable workaround. Let me bug them....

@hakman
Copy link
Member

hakman commented May 17, 2024

FYI @dims @hakuna-matatah ^^^

@hakman hakman mentioned this pull request May 17, 2024
Merged
@hakman
Copy link
Member

hakman commented May 17, 2024

/test pull-cloud-provider-aws-e2e

@hakman
Copy link
Member

hakman commented May 17, 2024 •
edited
Loading

Attempting to fix the dual-stack issue via kubernetes/kops#16575.
Looks like it worked, but would appreciate a double check.

@cartermckinnon
Copy link
Contributor

cartermckinnon commented May 17, 2024 •
edited
Loading

thank you @hakman!

@cartermckinnon
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 17, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cartermckinnon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 17, 2024
@k8s-ci-robot k8s-ci-robot merged commit 68cbc26 into master May 17, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cartermckinnon cartermckinnon Awaiting requested review from cartermckinnon

@olemarkus olemarkus Awaiting requested review from olemarkus

Assignees

@cartermckinnon cartermckinnon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@k8s-ci-robot @hakman @cartermckinnon @ameukam @actions-user