Ensuring nodelabel will be always present#923
Merged
thebsdbox merged 3 commits intokube-vip:mainfrom Jan 6, 2025
Merged
Conversation
Ensuring nodelabel will be always present
Collaborator
|
Hello, Sorry for the delay. Would it be possible to address the linting issue? |
Contributor
Author
Hello Done |
Collaborator
|
@cdtzabra linter is still unhappy with your code. |
Cellebyte
reviewed
Nov 15, 2024
| // Append label | ||
| applyPatchLabels(ctx, clientSet, id, "add", path, address) | ||
| } else if ok && value == address { | ||
| log.Debugf("Received identity: %s - id: %$", identity, id) |
Collaborator
There was a problem hiding this comment.
Suggested change
| log.Debugf("Received identity: %s - id: %$", identity, id) | |
| log.Debugf("Received identity: %s - id: %s", identity, id) |
Collaborator
|
Other than that LGTM :) |
Collaborator
|
Going to merge this and then fix in a corresponding PR 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As reported in the issue #863, nodelabel is missing sometimes.
for example, if the VIP is already associated with a node and you delete the kube-vip pods, once they're re-created, there's a good chance that none of your nodes will include the kube-vip/has-ip=xx label.
As a result, the existence of this label is unreliable.
The aim of this change is to ensure that the nodelabel is always added.