Consolidate file read to a single function #761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ygalblum
force-pushed
the
consolidate-reader
branch
from
660a737 to
7691c02
Compare
Create a single GetReader function for all sources Adjust all Reader operations to use the new function Adjust APIs where needed Remove the redundant embedConfig flag from Prometheus and Alert Manager Make age EmbedFS field a pointer to allow simple check Signed-off-by: Ygal Blum <[email protected]>
ygalblum
force-pushed
the
consolidate-reader
branch
from
7691c02 to
8fb8131
Compare
ygalblum
changed the title
5 tasks
rsevilla87
added a commit
that referenced
this pull request
Jan 3, 2025
## Type of change - [ ] Refactor - [ ] New feature - [x] Bug fix - [ ] Optimization - [ ] Documentation Update ## Description Reading profiles from embedded was not working since #761 ## Related Tickets & Documents - Related Issue # - Closes # Signed-off-by: Raul Sevilla <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Create a single GetReader function for all sources
Adjust all Reader operations to use the new function
Adjust APIs where needed
Remove the redundant embedConfig flag from Prometheus and Alert Manager
Make the EmbedFS field a pointer to allow simple check
Related Tickets & Documents
When using via
kube-burner-ocppatch jobType could not read from the embedded file system.