Remove global variables from job #740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rsevilla87 I didn't squash the commits to make it easier to review how each variable is removed |
seems lt needs some rebase after the latest commits |
ygalblum
force-pushed
the
remove-global-vars
branch
from
80713c9 to
83e680b
Compare
Done |
Signed-off-by: Ygal Blum <[email protected]>
Signed-off-by: Ygal Blum <[email protected]>
Signed-off-by: Ygal Blum <[email protected]>
Signed-off-by: Ygal Blum <[email protected]>
Signed-off-by: Ygal Blum <[email protected]>
ygalblum
force-pushed
the
remove-global-vars
branch
from
83e680b to
f57c7c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Global variables are in general a cause for issues; they can be set unexpectedly (or not set at all), they can be misused, etc. Instead, local variables, method parameters and instance fields should be used.