Copy the labels to the underlying template even if it does not have any #737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsevilla87
reviewed
Nov 15, 2024
ygalblum
force-pushed
the
force-adding-labels
branch
from
983187a to
4179544
Compare
Signed-off-by: Ygal Blum <[email protected]>
ygalblum
force-pushed
the
force-adding-labels
branch
from
4179544 to
8527752
Compare
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
kube-burner copies the labels of its created objects into the template of the underlying object (e.g. pod template of a deployment). These labels are then used in other places in the code. For example, metrics measurements rely on the existence of the
kube-burner-runidlabel on the pod (or VMI in case of VMs).In the original code, the labels were copied only if the labels field already existed.
With these fix, for specific kinds, the labels are copied even if none were added.
Related Tickets & Documents