-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New PodReadyToStartContainers condition to pod_latency measurement #716
Merged
rsevilla87
merged 3 commits into
kube-burner:main
from
rsevilla87:PodReadyToStartContainers
Nov 19, 2024
Merged
New PodReadyToStartContainers condition to pod_latency measurement #716
rsevilla87
merged 3 commits into
kube-burner:main
from
rsevilla87:PodReadyToStartContainers
Nov 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsevilla87
requested review from
afcollins,
jtaleric,
vishnuchalla,
dry923,
josecastillolema and
smalleni
October 29, 2024 08:50
vishnuchalla
reviewed
Nov 8, 2024
vishnuchalla
reviewed
Nov 8, 2024
vishnuchalla
reviewed
Nov 8, 2024
Signed-off-by: Raul Sevilla <[email protected]>
Signed-off-by: Raul Sevilla <[email protected]>
rsevilla87
force-pushed
the
PodReadyToStartContainers
branch
from
November 13, 2024 09:47
f1c4de3
to
bcbbccb
Compare
Signed-off-by: Raul Sevilla <[email protected]>
rsevilla87
force-pushed
the
PodReadyToStartContainers
branch
from
November 19, 2024 16:00
bcbbccb
to
c1559bc
Compare
vishnuchalla
approved these changes
Nov 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
cc: @mukrishn |
mukrishn
approved these changes
Nov 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Very interesting new pod condition, enabled by default as of k8s 1.29 (OCP 4.16)
More info at https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle/#pod-has-network
We can look at it to establish a new KPI directly inherited from CNI performance
Related Tickets & Documents